From b7179b5858c2f3393407777e5ba0d9c6b0e9720b Mon Sep 17 00:00:00 2001
From: Devlin Junker <devlin.junker@gmail.com>
Date: Tue, 26 Sep 2023 14:39:38 -0700
Subject: [PATCH 1/5] working share component

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
---
 src/components/ShareItem.vue                | 138 ++++++++++++++++++++
 src/components/Sidebar.vue                  |   2 +-
 src/components/feed-display/FeedItemRow.vue |  20 +--
 src/dataservices/share.service.ts           |  28 ++++
 4 files changed, 179 insertions(+), 9 deletions(-)
 create mode 100644 src/components/ShareItem.vue
 create mode 100644 src/dataservices/share.service.ts

diff --git a/src/components/ShareItem.vue b/src/components/ShareItem.vue
new file mode 100644
index 000000000..c7898330c
--- /dev/null
+++ b/src/components/ShareItem.vue
@@ -0,0 +1,138 @@
+<template>
+	<NcModal @close="$emit('close')">
+		<div id="share-item">
+			<form name="feedform">
+				<fieldset>
+					<input v-model="userName"
+						type="text"
+						:placeholder="t('news', 'User Name')"
+						name="user"
+						pattern="[^\s]+"
+						required
+						autofocus
+						@keyup="debounceSearchUsers()">
+
+					<div class="user-bubble-container">
+						<NcLoadingIcon v-if="searching" />
+						<NcUserBubble v-for="user in users"
+							v-else-if="!searching"
+							:key="user.shareName"
+							:size="30"
+							:display-name="user.displayName"
+							:primary="selected.map((val) => { return val.shareName }).includes(user.shareName)"
+							:user="user.shareName"
+							@click="clickUser(user)" />
+					</div>
+
+					<NcButton :wide="true"
+						type="primary"
+						:disabled="selected.length === 0"
+						@click="share()">
+						<template v-if="selected.length === 0">
+							{{ t("news", "Share") }}
+						</template>
+						<template v-else-if="selected.length === 1">
+							{{ t("news", "Share with") + ' ' + selected[0].displayName }}
+						</template>
+						<template v-else-if="selected.length > 1">
+							{{ t("news", "Share with {num} users", { num: selected.length }) }}
+						</template>
+					</NcButton>
+				</fieldset>
+			</form>
+		</div>
+	</NcModal>
+</template>
+
+<script lang="ts">
+
+import Vue from 'vue'
+import _ from 'lodash'
+
+import NcModal from '@nextcloud/vue/dist/Components/NcModal.js'
+import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
+import NcUserBubble from '@nextcloud/vue/dist/Components/NcUserBubble.js'
+import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
+
+import { ShareService } from '../dataservices/share.service'
+
+export default Vue.extend({
+	components: {
+		NcModal,
+		NcButton,
+		NcUserBubble,
+		NcLoadingIcon,
+	},
+	props: {
+		itemId: {
+			type: Number,
+			required: true,
+		},
+	},
+	data: () => {
+		return {
+			userName: '',
+			users: [],
+			selected: [],
+			searching: false,
+		} as any
+	},
+	created() {
+		this.debounceSearchUsers = _.debounce(this.searchUsers, 800)
+	},
+	methods: {
+		clickUser(user: any) {
+			const selectedUsers = this.selected.map((val: any) => { return val.shareName })
+			if (selectedUsers.includes(user.shareName)) {
+				this.selected.splice(selectedUsers.indexOf(user.shareName), 1)
+			} else {
+				this.selected.push(user)
+			}
+		},
+
+		async searchUsers() {
+			this.users = []
+			this.searching = true
+			const response = await ShareService.fetchUsers(this.userName)
+			this.searching = false
+
+			for (const user of response.data.ocs.data.users) {
+				this.users.push({ displayName: user.label, shareName: user.value.shareWith })
+			}
+		},
+
+		/**
+		 * Shares an item with another use in the same nextcloud instance
+		 */
+		async share() {
+			await ShareService.share(this.itemId, this.selected.map((val: any) => { return val.shareName }))
+
+			this.$emit('close')
+		},
+	},
+})
+
+</script>
+
+<style>
+#share-item .user-bubble__content * {
+  cursor: pointer;
+}
+
+#share-item fieldset {
+  padding: 16px;
+}
+
+#share-item input {
+  width: 90%;
+}
+
+#share-item .user-bubble-container {
+  margin: 10px;
+}
+
+#share-item .user-bubble__wrapper {
+  margin: 5px 10px;
+}
+
+</style>
diff --git a/src/components/Sidebar.vue b/src/components/Sidebar.vue
index 392c0ccfb..f29e6503e 100644
--- a/src/components/Sidebar.vue
+++ b/src/components/Sidebar.vue
@@ -84,7 +84,7 @@
 					</NcCounterBubble>
 				</template>
 				<template #actions>
-					<SidebarFeedLinkActions v-if="topLevelItem.name === undefined" :feed-id="topLevelItem.id" />
+					<SidebarFeedLinkActions v-if="topLevelItem.name === undefined && !topLevelItem.url.includes('news/sharedwithme')" :feed-id="topLevelItem.id" />
 
 					<NcActionButton v-if="topLevelItem.name !== undefined" icon="icon-checkmark" @click="markFolderRead(topLevelItem)">
 						{{ t("news", "Mark read") }}
diff --git a/src/components/feed-display/FeedItemRow.vue b/src/components/feed-display/FeedItemRow.vue
index 03670295a..854f83633 100644
--- a/src/components/feed-display/FeedItemRow.vue
+++ b/src/components/feed-display/FeedItemRow.vue
@@ -1,5 +1,6 @@
 <template>
 	<div class="feed-item-row" @click="select()">
+		<ShareItem v-if="showShareMenu" :item-id="shareItem" @close="closeShareMenu()" />
 		<div class="link-container">
 			<a class="external"
 				target="_blank"
@@ -28,14 +29,9 @@
 			<EyeIcon v-if="item.unread && !keepUnread" @click="toggleKeepUnread(item)" />
 			<EyeCheckIcon v-if="!item.unread && !keepUnread" @click="toggleKeepUnread(item)" />
 			<EyeLockIcon v-if="keepUnread" class="keep-unread" @click="toggleKeepUnread(item)" />
-			<NcActions :force-menu="true">
-				<template #icon>
-					<ShareVariant />
-				</template>
-				<NcActionButton>
-					<template #default>
-						<!-- TODO: Share Menu --> TODO
-					</template>
+			<NcActions>
+				<NcActionButton :title="t('news', 'Share within Instance')" @click="shareItem = item.id; showShareMenu = true">
+					{{ t('news', 'Share') }}
 					<template #icon>
 						<ShareVariant />
 					</template>
@@ -60,6 +56,8 @@ import ShareVariant from 'vue-material-design-icons/ShareVariant.vue'
 import NcActions from '@nextcloud/vue/dist/Components/NcActions.js'
 import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
 
+import ShareItem from '../ShareItem.vue'
+
 import { Feed } from '../../types/Feed'
 import { FeedItem } from '../../types/FeedItem'
 import { ACTIONS, MUTATIONS } from '../../store'
@@ -76,6 +74,7 @@ export default Vue.extend({
 		RssIcon,
 		NcActions,
 		NcActionButton,
+		ShareItem,
 	},
 	props: {
 		item: {
@@ -86,6 +85,8 @@ export default Vue.extend({
 	data: () => {
 		return {
 			keepUnread: false,
+			showShareMenu: false,
+			shareItem: undefined,
 		}
 	},
 	computed: {
@@ -142,6 +143,9 @@ export default Vue.extend({
 		toggleStarred(item: FeedItem): void {
 			this.$store.dispatch(item.starred ? ACTIONS.UNSTAR_ITEM : ACTIONS.STAR_ITEM, { item })
 		},
+		closeShareMenu() {
+			this.showShareMenu = false
+		},
 	},
 })
 
diff --git a/src/dataservices/share.service.ts b/src/dataservices/share.service.ts
new file mode 100644
index 000000000..c060bc3f0
--- /dev/null
+++ b/src/dataservices/share.service.ts
@@ -0,0 +1,28 @@
+import { AxiosResponse } from 'axios'
+import axios from '@nextcloud/axios'
+import { generateOcsUrl } from '@nextcloud/router'
+
+export class ShareService {
+
+	/**
+	 * Retrieves all of users matching the search term
+	 *
+	 * @param query {String} search string
+	 * @return {AxiosResponse} Folders contained in data.folders property
+	 */
+	static fetchUsers(query: string): Promise<AxiosResponse> {
+		return axios.get(generateOcsUrl(`apps/files_sharing/api/v1/sharees?search=${query}&itemType=news_item&perPage=5/`))
+	}
+
+	static async share(id: number, users: string[]): Promise<boolean> {
+		const promises = []
+		for (const shareName of users) {
+			promises.push(axios.post(`items/${id}/share/${shareName}`))
+		}
+
+		await Promise.all(promises)
+
+		return true
+	}
+
+}

From 816ef83bd0738e3207a7dc106fd0a95b9b59baea Mon Sep 17 00:00:00 2001
From: Devlin Junker <devlin.junker@gmail.com>
Date: Tue, 26 Sep 2023 14:55:32 -0700
Subject: [PATCH 2/5] reuse ShareItem component in FeedItemDisplay

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
---
 lib/Service/ShareService.php                  |  2 ++
 .../feed-display/FeedItemDisplay.vue          | 21 ++++++++++++-------
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/lib/Service/ShareService.php b/lib/Service/ShareService.php
index 552e1d9a4..1ba69b612 100644
--- a/lib/Service/ShareService.php
+++ b/lib/Service/ShareService.php
@@ -114,6 +114,8 @@ public function shareItemWithUser(string $userId, int $itemId, string $shareReci
         $sharedItem->setStarred(false);
         $sharedItem->setSharedBy($userId);
 
+        // TODO: should we set the pub date to the date of share?
+
         // Get 'shared with me' dummy feed
         $feedUrl = $this->urlGenerator->getBaseUrl() . '/news/sharedwithme';
         $feed = $this->feedService->findByUrl($shareRecipientId, $feedUrl);
diff --git a/src/components/feed-display/FeedItemDisplay.vue b/src/components/feed-display/FeedItemDisplay.vue
index 8d97e856e..c22db1772 100644
--- a/src/components/feed-display/FeedItemDisplay.vue
+++ b/src/components/feed-display/FeedItemDisplay.vue
@@ -1,14 +1,11 @@
 <template>
 	<div class="feed-item-display">
+		<ShareItem v-if="showShareMenu" :item-id="item.id" @close="closeShareMenu()" />
+
 		<div class="action-bar">
-			<NcActions :force-menu="true">
-				<template #icon>
-					<ShareVariant />
-				</template>
-				<NcActionButton>
-					<template #default>
-						<!-- TODO: Share Menu --> TODO
-					</template>
+			<NcActions>
+				<NcActionButton :title="t('news', 'Share within Instance')" @click="showShareMenu = true">
+					{{ t('news', 'Share') }}
 					<template #icon>
 						<ShareVariant />
 					</template>
@@ -101,6 +98,8 @@ import CloseIcon from 'vue-material-design-icons/Close.vue'
 import NcActions from '@nextcloud/vue/dist/Components/NcActions.js'
 import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
 
+import ShareItem from '../ShareItem.vue'
+
 import { Feed } from '../../types/Feed'
 import { FeedItem } from '../../types/FeedItem'
 import { ACTIONS, MUTATIONS } from '../../store'
@@ -113,6 +112,7 @@ export default Vue.extend({
 		ShareVariant,
 		NcActions,
 		NcActionButton,
+		ShareItem,
 	},
 	props: {
 		item: {
@@ -123,6 +123,7 @@ export default Vue.extend({
 	data: () => {
 		return {
 			keepUnread: false,
+			showShareMenu: false,
 		}
 	},
 	computed: {
@@ -171,6 +172,10 @@ export default Vue.extend({
 			this.$store.dispatch(item.starred ? ACTIONS.UNSTAR_ITEM : ACTIONS.STAR_ITEM, { item })
 		},
 
+		closeShareMenu() {
+			this.showShareMenu = false
+		},
+
 		getMediaType(mime: string): 'audio' | 'video' | false {
 			// TODO: figure out how to check media type
 			return false

From 74eb3150e204f79053e6a6a7ad35b0b6f91c3fde Mon Sep 17 00:00:00 2001
From: Devlin Junker <devlin.junker@gmail.com>
Date: Tue, 26 Sep 2023 15:08:48 -0700
Subject: [PATCH 3/5] use translation method params for relative timestamp

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
---
 src/components/feed-display/FeedItemRow.vue | 12 ++++++------
 src/shims-vue.d.ts                          |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/components/feed-display/FeedItemRow.vue b/src/components/feed-display/FeedItemRow.vue
index 854f83633..a84f0a907 100644
--- a/src/components/feed-display/FeedItemRow.vue
+++ b/src/components/feed-display/FeedItemRow.vue
@@ -115,17 +115,17 @@ export default Vue.extend({
 			const elapsed = current - previous
 
 			if (elapsed < msPerMinute) {
-				return Math.round(elapsed / 1000) + ' ' + t('news', 'seconds')
+				return t('news', '{num} seconds', { num: Math.round(elapsed / 1000) })
 			} else if (elapsed < msPerHour) {
-				return Math.round(elapsed / msPerMinute) + ' ' + t('news', 'minutes ago')
+				return t('news', '{num} minutes ago', { num: Math.round(elapsed / msPerMinute) })
 			} else if (elapsed < msPerDay) {
-				return Math.round(elapsed / msPerHour) + ' ' + t('news', 'hours ago')
+				return t('news', '{num} hours ago', { num: Math.round(elapsed / msPerHour) })
 			} else if (elapsed < msPerMonth) {
-				return Math.round(elapsed / msPerDay) + ' ' + t('news', 'days ago')
+				return t('news', '{num} days ago', { num: Math.round(elapsed / msPerDay) })
 			} else if (elapsed < msPerYear) {
-				return Math.round(elapsed / msPerMonth) + ' ' + t('news', 'months ago')
+				return t('news', '{num} months ago', { num: Math.round(elapsed / msPerMonth) })
 			} else {
-				return Math.round(elapsed / msPerYear) + ' ' + t('news', 'years ago')
+				return t('news', '{num} years ago', { num: Math.round(elapsed / msPerYear) })
 			}
 		},
 		getFeed(id: number): Feed {
diff --git a/src/shims-vue.d.ts b/src/shims-vue.d.ts
index e22ed2261..45931a53d 100644
--- a/src/shims-vue.d.ts
+++ b/src/shims-vue.d.ts
@@ -12,4 +12,4 @@ declare module '@nextcloud/vue/dist/Components/*' {
 };
 
 // Necessary to access translate in typescript components
-function t(app, key): string { }
\ No newline at end of file
+function t(app, key, params?): string { }
\ No newline at end of file

From ba9d512239eb5ed9b80648cfde291d483e6e390e Mon Sep 17 00:00:00 2001
From: Devlin Junker <devlin.junker@gmail.com>
Date: Tue, 26 Sep 2023 15:54:33 -0700
Subject: [PATCH 4/5] tests

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
---
 src/components/ShareItem.vue                  | 27 ++++++-
 .../unit/components/ShareItem.spec.ts         | 75 +++++++++++++++++++
 .../feed-display/FeedItemRow.spec.ts          |  4 +-
 .../unit/services/share.service.spec.ts       | 46 ++++++++++++
 4 files changed, 146 insertions(+), 6 deletions(-)
 create mode 100644 tests/javascript/unit/components/ShareItem.spec.ts
 create mode 100644 tests/javascript/unit/services/share.service.spec.ts

diff --git a/src/components/ShareItem.vue b/src/components/ShareItem.vue
index c7898330c..195f129be 100644
--- a/src/components/ShareItem.vue
+++ b/src/components/ShareItem.vue
@@ -56,6 +56,11 @@ import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
 
 import { ShareService } from '../dataservices/share.service'
 
+type ShareUser = {
+  shareName: string;
+  displayName: string;
+}
+
 export default Vue.extend({
 	components: {
 		NcModal,
@@ -75,14 +80,25 @@ export default Vue.extend({
 			users: [],
 			selected: [],
 			searching: false,
-		} as any
+		} as {
+      userName: string;
+      users: ShareUser[];
+      selected: ShareUser[];
+      searching: boolean;
+      debounceSearchUsers?: () => void;
+    }
 	},
 	created() {
 		this.debounceSearchUsers = _.debounce(this.searchUsers, 800)
 	},
 	methods: {
-		clickUser(user: any) {
-			const selectedUsers = this.selected.map((val: any) => { return val.shareName })
+		/**
+		 * Adds or removes user to selected list
+		 *
+		 * @param user {ShareUser} user that was clicked
+		 */
+		clickUser(user: ShareUser) {
+			const selectedUsers = this.selected.map((val: ShareUser) => { return val.shareName })
 			if (selectedUsers.includes(user.shareName)) {
 				this.selected.splice(selectedUsers.indexOf(user.shareName), 1)
 			} else {
@@ -90,6 +106,9 @@ export default Vue.extend({
 			}
 		},
 
+		/**
+		 * Searches for Users based on user input to display for sharing
+		 */
 		async searchUsers() {
 			this.users = []
 			this.searching = true
@@ -105,7 +124,7 @@ export default Vue.extend({
 		 * Shares an item with another use in the same nextcloud instance
 		 */
 		async share() {
-			await ShareService.share(this.itemId, this.selected.map((val: any) => { return val.shareName }))
+			await ShareService.share(this.itemId, this.selected.map((val: ShareUser) => { return val.shareName }))
 
 			this.$emit('close')
 		},
diff --git a/tests/javascript/unit/components/ShareItem.spec.ts b/tests/javascript/unit/components/ShareItem.spec.ts
new file mode 100644
index 000000000..f61c9e82b
--- /dev/null
+++ b/tests/javascript/unit/components/ShareItem.spec.ts
@@ -0,0 +1,75 @@
+import { shallowMount, createLocalVue } from '@vue/test-utils'
+import ShareItem from '../../../../src/components/ShareItem.vue'
+import { ShareService } from '../../../../src/dataservices/share.service'
+
+describe('AddFeed.vue', () => {
+	'use strict'
+
+	let wrapper: any
+	beforeEach(() => {
+		const localVue = createLocalVue()
+		wrapper = shallowMount(ShareItem, {
+			localVue,
+			propsData: {
+				itemId: 123,
+			},
+		})
+	})
+
+	describe('clickUser()', () => {
+		it('should add to selected if user not selected before', () => {
+			wrapper.vm.selected = []
+
+			wrapper.vm.clickUser({ displayName: 'display', shareName: 'share' })
+
+			expect(wrapper.vm.selected.length).toEqual(1)
+		})
+
+		it('should remove from selected if user is selected before', () => {
+			wrapper.vm.selected = [{ displayName: 'display', shareName: 'share' }]
+
+			wrapper.vm.clickUser({ displayName: 'display', shareName: 'share' })
+
+			expect(wrapper.vm.selected.length).toEqual(0)
+		})
+	})
+
+	describe('searchUsers()', () => {
+		it('should call ShareService to fetch users to add to user (display) list', async () => {
+			ShareService.fetchUsers = jest.fn().mockReturnValue({
+				data: {
+					ocs: {
+						data: {
+							users: [],
+						},
+					},
+				},
+			})
+			wrapper.vm.userName = 'search'
+
+			await wrapper.vm.searchUsers()
+
+			expect(ShareService.fetchUsers).toBeCalled()
+		})
+	})
+
+	describe('share()', () => {
+		it('should call ShareService to share article id with backend', async () => {
+			ShareService.share = jest.fn()
+			wrapper.vm.selected = [{ displayName: 'display', shareName: 'share' }]
+
+			await wrapper.vm.share()
+
+			expect(ShareService.share).toBeCalled()
+
+			wrapper.vm.selected = [{ displayName: 'display', shareName: 'share' }, { displayName: 'display2', shareName: 'share2' }]
+
+			await wrapper.vm.share()
+
+			let args = (ShareService.share as any).mock.calls[0]
+			expect(args[1]).toEqual(['share'])
+			args = (ShareService.share as any).mock.calls[1]
+			expect(args[1]).toEqual(['share', 'share2'])
+		})
+	})
+})
diff --git a/tests/javascript/unit/components/feed-display/FeedItemRow.spec.ts b/tests/javascript/unit/components/feed-display/FeedItemRow.spec.ts
index d6aa2cd9d..8c4b23042 100644
--- a/tests/javascript/unit/components/feed-display/FeedItemRow.spec.ts
+++ b/tests/javascript/unit/components/feed-display/FeedItemRow.spec.ts
@@ -68,13 +68,13 @@ describe('FeedItemRow.vue', () => {
 
 		let relativeTimestamp = (wrapper.vm as any).getRelativeTimestamp(pastTimestamp)
 
-		expect(relativeTimestamp).toEqual('10 seconds')
+		expect(relativeTimestamp).toEqual('{num} seconds')
 
 		pastTimestamp = currentTimestamp - 1000 * 60 * 10 // 10 minutes ago
 
 		relativeTimestamp = (wrapper.vm as any).getRelativeTimestamp(pastTimestamp)
 
-		expect(relativeTimestamp).toEqual('10 minutes ago')
+		expect(relativeTimestamp).toEqual('{num} minutes ago')
 	})
 
 	it('should retrieve feed by ID', () => {
diff --git a/tests/javascript/unit/services/share.service.spec.ts b/tests/javascript/unit/services/share.service.spec.ts
new file mode 100644
index 000000000..678c0eebf
--- /dev/null
+++ b/tests/javascript/unit/services/share.service.spec.ts
@@ -0,0 +1,46 @@
+import { ShareService } from './../../../../src/dataservices/share.service'
+import axios from '@nextcloud/axios'
+
+jest.mock('@nextcloud/axios')
+
+describe('share.service.ts', () => {
+	'use strict'
+
+	beforeEach(() => {
+		(axios.get as any).mockReset();
+		(axios.post as any).mockReset()
+	})
+
+	describe('fetchUsers', () => {
+		it('should call GET to retrieve users', async () => {
+			(axios as any).get.mockResolvedValue({ data: { feeds: [] } })
+
+			await ShareService.fetchUsers('abc')
+
+			expect(axios.get).toBeCalled()
+			const args = (axios.get as any).mock.calls[0]
+
+			expect(args[0]).toContain('search=abc')
+		})
+	})
+
+	describe('share', () => {
+		it('should call POST for each user passed', async () => {
+			await ShareService.share(123, ['share-user'])
+
+			expect(axios.post).toBeCalledTimes(1)
+			let args = (axios.post as any).mock.calls[0]
+
+			expect(args[0]).toContain('123/share/share-user')
+
+			await ShareService.share(345, ['share-user', 'share2'])
+
+			expect(axios.post).toBeCalledTimes(3)
+
+			args = (axios.post as any).mock.calls[1]
+			expect(args[0]).toContain('345/share/share-user')
+			args = (axios.post as any).mock.calls[2]
+			expect(args[0]).toContain('345/share/share2')
+		})
+	})
+})

From 883b7b53682290bb4e6bb2ceb2e8cf5362ee0de5 Mon Sep 17 00:00:00 2001
From: Devlin Junker <devlin.junker@gmail.com>
Date: Mon, 2 Oct 2023 19:37:54 -0700
Subject: [PATCH 5/5] fix length of line

Signed-off-by: Devlin Junker <devlin.junker@gmail.com>
---
 lib/Plugin/Client/Plugin.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Plugin/Client/Plugin.php b/lib/Plugin/Client/Plugin.php
index 66252916c..ff4cdae05 100644
--- a/lib/Plugin/Client/Plugin.php
+++ b/lib/Plugin/Client/Plugin.php
@@ -14,7 +14,7 @@
 namespace OCA\News\Plugin\Client;
 
 /**
- * TODO: remove this? it seems old.. there is no global list of plugins anymore and seems like plugins register themselves
+ * TODO: remove this? it seems old.. there is no global list of plugins and seems plugins register themselves?
  *
  * We actually really want to avoid this global list of plugins. A way would be
  * for News plugin apps to register themselves in a special database table