From 7c11fd21bb67194287d67905304e79d7b1abf580 Mon Sep 17 00:00:00 2001 From: Wolfgang Date: Mon, 2 Dec 2024 22:27:49 +0100 Subject: [PATCH 1/6] fix: set correct focus when opening modals Signed-off-by: Wolfgang --- src/components/AddFeed.vue | 5 ++++- src/components/ShareItem.vue | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/AddFeed.vue b/src/components/AddFeed.vue index 527f938d3..074b4dce8 100644 --- a/src/components/AddFeed.vue +++ b/src/components/AddFeed.vue @@ -3,7 +3,8 @@
- this.$refs?.feedInput?.focus()) + }, methods: { /** diff --git a/src/components/ShareItem.vue b/src/components/ShareItem.vue index e106ebcc9..90dc3fdcf 100644 --- a/src/components/ShareItem.vue +++ b/src/components/ShareItem.vue @@ -3,7 +3,8 @@
- this.$refs?.nameInput?.focus()) + }, methods: { /** From c0618dc533a9244bc2d7835f17a95501c88117b0 Mon Sep 17 00:00:00 2001 From: Wolfgang Date: Mon, 2 Dec 2024 23:25:29 +0100 Subject: [PATCH 2/6] fix: add item url to open website aria label and remove unecessary title from heading link Signed-off-by: Wolfgang --- src/components/feed-display/FeedItemRow.vue | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/components/feed-display/FeedItemRow.vue b/src/components/feed-display/FeedItemRow.vue index 9f763b618..2354a0977 100644 --- a/src/components/feed-display/FeedItemRow.vue +++ b/src/components/feed-display/FeedItemRow.vue @@ -12,6 +12,7 @@ rel="noreferrer" :href="item.url" :title="t('news', 'Open website')" + :aria-label="`${t('news', 'Open website')} ${item.url}`" @click.middle="markRead(item); $event.stopPropagation();" @click="markRead(item); $event.stopPropagation();"> - + {{ item.title }} From 036651b5e81c533b59269c0bac79e732cf25bba8 Mon Sep 17 00:00:00 2001 From: Wolfgang Date: Mon, 2 Dec 2024 23:32:42 +0100 Subject: [PATCH 3/6] fix: remove close button in screen reader mode Signed-off-by: Wolfgang --- src/components/feed-display/FeedItemDisplay.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/feed-display/FeedItemDisplay.vue b/src/components/feed-display/FeedItemDisplay.vue index 8ec8b2bc1..4e71f22ad 100644 --- a/src/components/feed-display/FeedItemDisplay.vue +++ b/src/components/feed-display/FeedItemDisplay.vue @@ -26,7 +26,8 @@ :title="t('news', 'Mark unread')" tabindex="0" @click="toggleRead(item)" /> -
- - - - - + + + {{ t('news', 'Toggle star article') }} + + + + {{ t('news', 'Keep article unread') }} + + + + {{ t('news', 'Toggle keep current article unread') }} + + + + {{ t('news', 'Remove keep article unread') }} + + - {{ t('news', 'Share') }} + {{ t('news', 'Share within Instance') }} @@ -304,6 +318,7 @@ export default Vue.extend({ .feed-item-row .date-container.compact { flex: 0 0 auto; font-size: small; + padding-right: 4px; } .feed-item-row .button-container { @@ -312,11 +327,14 @@ export default Vue.extend({ align-self: center; } - .feed-item-row .button-container .button-vue, .feed-item-row .button-container .button-vue .button-vue__wrapper, .feed-item-row .button-container .material-design-icon { - width: 30px !important; - min-width: 30px; - min-height: 30px; - height: 30px; + .feed-item-row .button-container .button-vue, + .feed-item-row .button-container .button-vue .button-vue__wrapper, + .feed-item-row .button-container .material-design-icon + { + width: 24px !important; + min-width: 24px; + min-height: 24px; + height: 24px; } .feed-item-row .button-container .material-design-icon { From 4df313112ac85952b0dcf8fdbe4f84a212040152 Mon Sep 17 00:00:00 2001 From: Wolfgang Date: Tue, 3 Dec 2024 20:42:53 +0100 Subject: [PATCH 5/6] add changelog for accessibility improvements Signed-off-by: Wolfgang --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a67c66ad..aadf2ed8b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,10 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the - Show red error bubble only if more than 8 updates fail. ### Fixed +- set correct input focus when opening `AddFeed` or `Share` modals +- add item url to open website button aria label for screen readers +- allow using `toggle starred` and `mark read` icons with keyboard +- remove close button from list items in screen reader mode # Releases ## [25.1.0] - 2024-12-01 From 0754cb2363067bfe3506bece2f5f32bf6802dd2e Mon Sep 17 00:00:00 2001 From: Wolfgang Date: Tue, 3 Dec 2024 20:46:08 +0100 Subject: [PATCH 6/6] fix: mark read on scroll marks visible items as read using vertical compact display mode Signed-off-by: Wolfgang --- CHANGELOG.md | 1 + src/components/feed-display/FeedItemRow.vue | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index aadf2ed8b..cfeb385d1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the - add item url to open website button aria label for screen readers - allow using `toggle starred` and `mark read` icons with keyboard - remove close button from list items in screen reader mode +- mark read on scroll marks visible items as read using vertical compact display mode # Releases ## [25.1.0] - 2024-12-01 diff --git a/src/components/feed-display/FeedItemRow.vue b/src/components/feed-display/FeedItemRow.vue index ee3deee03..6acfc235a 100644 --- a/src/components/feed-display/FeedItemRow.vue +++ b/src/components/feed-display/FeedItemRow.vue @@ -31,9 +31,9 @@ -
+
- +