Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept ISO 8601 dates in augur filter's max-date and min-date #567

Closed
kairstenfay opened this issue Jun 17, 2020 · 2 comments · Fixed by #568
Closed

Accept ISO 8601 dates in augur filter's max-date and min-date #567

kairstenfay opened this issue Jun 17, 2020 · 2 comments · Fixed by #568
Labels
enhancement New feature or request

Comments

@kairstenfay
Copy link
Contributor

kairstenfay commented Jun 17, 2020

Context
When providing an argument to augur filter's --max-date option, I automatically gave it an ISO 8601 date string (e.g. '2020-06-15'). Not being much of an augur user, I was surprised to learn that it only accepts float dates (e.g. 2020.46).

Description
Allow augur filter to accept ISO 8601 date strings along with date floats in a backwards compatible way.

More context can be found in this ncov PR thread.

@jameshadfield
Copy link
Member

👍 Small typo in the link to the ncov PR where this was discussed, it's at nextstrain/ncov#401

@kairstenfay
Copy link
Contributor Author

Ah, thank you, James. I updated the link so that it's now functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants