Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to x-axis in tree panel #941

Closed
trvrb opened this issue Mar 12, 2020 · 1 comment
Closed

Add label to x-axis in tree panel #941

trvrb opened this issue Mar 12, 2020 · 1 comment
Labels
enhancement New feature or request good first issue A relatively isolated issue appropriate for first-time contributors please take this issue

Comments

@trvrb
Copy link
Member

trvrb commented Mar 12, 2020

Currently the "Phylogeny" panel doesn't have a label for the x-axis:

x-axis

This lack of labeling is hugely confusing to outsiders and everyone knows this is poor data viz practice. Let's fix this. I recommend:

  • "Date" if showing a tree with mu=num_date.
  • "Mutations" if showing a tree with m=div and branch lengths are big enough to indicate this this measures substitutions rather than substitutions per site.
  • "Divergence" if showing a tree with m=div and branch lengths are small enough to indicate this this measures substitutions per site rather than substitutions.

Logic to test between Substitutions and Substitutions per site is here: 80915fd

I wouldn't worry about this labeling for "radial" or "unrooted" views.

@trvrb trvrb added enhancement New feature or request please take this issue good first issue A relatively isolated issue appropriate for first-time contributors labels Mar 12, 2020
@huddlej
Copy link
Contributor

huddlej commented Mar 14, 2020

Closed by #942

@huddlej huddlej closed this as completed Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue A relatively isolated issue appropriate for first-time contributors please take this issue
Projects
None yet
Development

No branches or pull requests

2 participants