Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type from method name write_source_waveform_broadcast_u32 #1105

Closed
marcoskirsch opened this issue Nov 11, 2019 · 4 comments · Fixed by #1127
Closed

Remove type from method name write_source_waveform_broadcast_u32 #1105

marcoskirsch opened this issue Nov 11, 2019 · 4 comments · Fixed by #1127
Assignees
@texasaggie97-zz
Labels
API nidigital priority-critical source-breaker

Comments

@marcoskirsch
Copy link
Member

Description of issue

nidigital has a method Session.write_source_waveform_broadcast_u32. In Python there is no U32 type. If the C function has a "U32" suffix because we think we may add other flavors of the function that is fine. In Python we should use "fancy" functions when that happens.
@marcoskirsch marcoskirsch mentioned this issue Nov 11, 2019
Merged
3 tasks
@texasaggie97-zz
Copy link
Contributor

Already in work with #1096

@sbethur
Copy link
Contributor

sbethur commented Nov 11, 2019

#1096 is for fetch_capture_waveform_u32. This issue is for write_source_waveform_broadcast_u32.

@sbethur sbethur reopened this Nov 11, 2019
@texasaggie97-zz
Copy link
Contributor

Oops. Missed that.

@marcoskirsch
Copy link
Member Author

marcoskirsch commented Nov 12, 2019 •
edited
Loading

Already in work with #1096

Even then, it should be closed only after #1096 gets merged.

@texasaggie97-zz texasaggie97-zz self-assigned this Nov 15, 2019
@texasaggie97-zz texasaggie97-zz mentioned this issue Nov 15, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@texasaggie97-zz texasaggie97-zz

Labels
API nidigital priority-critical source-breaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove u32 from write_source_waveform_broadcast_u32 ni/nimi-python
3 participants
@marcoskirsch @texasaggie97-zz @sbethur