Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for complex numbers in our NI-FGEN and NI-SCOPE APIs #514

Closed
Fladolcetta opened this issue Oct 20, 2017 · 4 comments
Closed

Comments

@Fladolcetta
Copy link
Contributor

Fladolcetta commented Oct 20, 2017

NI-FGEN and NI-SCOPE both support generating and acquiring complex waveforms. For example, NI-5541 and NI-5442 have Onboard Signal Processing that upconverts a complex waveform and generates it. The APIs use NIComplexI16 and NIComplexF64 to represent complex numbers.

nimi-python doesn't support those types.

@marcoskirsch
Copy link
Member

There are challenges and API design questions on how to best support those types (NIComplexF64 and NIComplexI16) in our Python APIs.

We estimate that only a very small number of clients use complex waveforms with NI-FGEN and NI-SCOPE – most of those customers use NI-RFSG and NI-RFSA which aren't in nimi-python and aren't planned for the 0.9 release.

Given this, and the sheer amount of work remaining, there's a pretty good change that we won't get to this.

@marcoskirsch marcoskirsch added this to the Post 0.9 Release milestone Oct 21, 2017
@marcoskirsch marcoskirsch changed the title Should we support complex numbers in our NI-FGEN and NI-SCOPE APIs? Need support for complex numbers in our NI-FGEN and NI-SCOPE APIs? Oct 21, 2017
@marcoskirsch marcoskirsch changed the title Need support for complex numbers in our NI-FGEN and NI-SCOPE APIs? Need support for complex numbers in our NI-FGEN and NI-SCOPE APIs Oct 21, 2017
@Fladolcetta
Copy link
Contributor Author

Closing item until demand is requested for Complex numbers.

@marcoskirsch
Copy link
Member

When we add this to NI-FGEN, we should keep the same signature for the public method and dispatch to the proper function internally if possible, rather than adding new public methods.

@MrDuff8
Copy link
Contributor

MrDuff8 commented Jul 25, 2019

We expect this is a low-priority item, and we haven't heard requests for it. It's very rare for this to be used on its own without an upconverter or downconverter, which we don't offer support for in python. Please comment if this is something your application needs.

@MrDuff8 MrDuff8 closed this as completed Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants