Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NidcpowerWarning name violates PEP8 #658

Closed
marcoskirsch opened this issue Dec 6, 2017 · 0 comments · Fixed by #841
Closed

NidcpowerWarning name violates PEP8 #658

marcoskirsch opened this issue Dec 6, 2017 · 0 comments · Fixed by #841
Labels
api-review nidcpower nidmm nifgen nimodinst niscope niswitch priority-medium source-breaker
Milestone
nimi-python 0.9 r...

Comments

@marcoskirsch
Copy link
Member

@epage:

At best, shouldn't that be "NiDcPowerWarning" or "NIDCPowerWarning"

Note that PEP8 says that acronyms should not be treated as a word (HTTP instead of Http)
See https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles
(I might have made mistakes with this in the past, granted, this is more of a corner case I'm not too worried about)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-review nidcpower nidmm nifgen nimodinst niscope niswitch priority-medium source-breaker
Projects
None yet
Milestone
nimi-python 0.9 release
Development

Successfully merging a pull request may close this issue.

Change Warning class name to be PEP8 compliant ni/nimi-python
2 participants
@marcoskirsch @Fladolcetta