Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anywhere a timedelta is used for parameter, also allow float in seconds #796

Closed
texasaggie97-zz opened this issue Apr 3, 2018 · 1 comment · Fixed by #803
Closed

Anywhere a timedelta is used for parameter, also allow float in seconds #796

texasaggie97-zz opened this issue Apr 3, 2018 · 1 comment · Fixed by #803

Comments

@texasaggie97-zz
Copy link
Contributor

This makes the function call less verbose.
Both will work:

  • fetch(timeout=datetime.timedelta(seconds=1.5))
  • fetch(timeout=1.5)
@Fladolcetta
Copy link
Contributor

Per discussion we have decided to allow both, this is because we see value in the ease of using a float in seconds and the self documentation of using timedelta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants