Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nifgen.Session.export_signal order parameter should match niscope and nidcpower #801

Closed
marcoskirsch opened this issue Apr 5, 2018 · 0 comments · Fixed by #802
Closed

nifgen.Session.export_signal order parameter should match niscope and nidcpower #801

marcoskirsch opened this issue Apr 5, 2018 · 0 comments · Fixed by #802
Labels
API enhancement nifgen source-breaker
Milestone
nimi-python 0.8 r...

Comments

@marcoskirsch
Copy link
Member

generated/nifgen/session.py:

    def export_signal(self, signal, signal_identifier, output_terminal):

is different from:

generated/niscope/session.py:

    def export_signal(self, signal, output_terminal, signal_identifier="None"):

generated/nidcpower/session.py:

    def export_signal(self, signal, output_terminal, signal_identifier=""):

We should add a reasonable default to nifgen so they all match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API enhancement nifgen source-breaker
Projects
None yet
Milestone
nimi-python 0.8 release
Development

Successfully merging a pull request may close this issue.

Add default value for nifgen export_signal signal_identifier parameter ni/nimi-python
1 participant
@marcoskirsch