Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify nidcpower, nifgen event configuration #859

Closed
marcoskirsch opened this issue May 17, 2018 · 2 comments · Fixed by #868
Closed

Simplify nidcpower, nifgen event configuration #859

marcoskirsch opened this issue May 17, 2018 · 2 comments · Fixed by #868

Comments

@marcoskirsch
Copy link
Member

marcoskirsch commented May 17, 2018

Zen of Python:

Simple is better than complex.

NI-FGEN (and to a lesser degree NI-DCPower) provides a lot of configurability for triggers and events. You can change polarity, play with pulse width, set them as level instead of pulses... It's extremely rare to configure these and it's also not supported by the "latest and greatest" NI-FGEN device family 54x3.

For those reasons, we should remove the properties for all events:

  • event_level_active_level
  • event_output_behavior
  • event_pulse_polarity
  • event_pulse_width
  • event_pulse_width_units
  • event_toggle_initial_state
  • event_live_status
  • event_latched_status
  • event_delay
  • event_delay_units

Keep:

  • event_output_terminal

For debate:

  • nidcpower.Session.measure_complete_event_delay: Is there still a reason to keep this around?
@marcoskirsch marcoskirsch changed the title Simplify nifgen event configuration Simplify nidcpower, nifgen event configuration May 17, 2018
@Fladolcetta Fladolcetta added this to the nimi-python 0.9 release milestone May 21, 2018
@marcoskirsch
Copy link
Member Author

nidcpower.Session.measure_complete_event_delay: Is there still a reason to keep this around?

What was the final decision on this?

@marcoskirsch
Copy link
Member Author

If any of these attributes are ever re-added, we should ensure that the enums are not duplicated for every single property. It should be possible to reuse the enums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants