Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nifgen methods that have "waveform handle" and "waveform name" should use fancy wrapper #862

Closed
marcoskirsch opened this issue May 17, 2018 · 0 comments · Fixed by #871
Closed

Comments

@marcoskirsch
Copy link
Member

For nifgen.Session.write_waveform, we created a Fancy Wrapper in which a parameter is either the waveform handle or the waveform name.

We found two instances that could and should do the same for consistency.

  • set_waveform_next_write_position and set_named_waveform_next_write_position
  • clear_arb_waveform and delete_named_waveform

The next_write_position methods are very niche, so we could just stop code-generating until a compelling use case arises. If that happens, we should make sure it's tracked via an issue.

@marcoskirsch marcoskirsch changed the title Functions that have "waveform handle" and "waveform name" should use fancy wrapper nifgen methods that have "waveform handle" and "waveform name" should use fancy wrapper May 17, 2018
@marcoskirsch marcoskirsch reopened this May 17, 2018
@Fladolcetta Fladolcetta added this to the nimi-python 1.0 release milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants