NS 14.2.6 no longer shows Temp Targets

[Foxy7]

Describe the bug
following update to NS 14.2.6 (from 14.2.5) our NS pages no longer show Temp Targets rendered.

Expected Behaviou
NSClient version of AAPS does show the Temp Target as active, between ~ 8am - 10am today:

Screenshots
NS does not show the grey Temp Target line:

Treatments report shows the correct data existing in the db:

Your setup information
Nightscout 14.2.6
All browsers have the same issue.
AAPS loading to Heroku.

thanks.

[sulkaharo]

Works for me using OpenAPS and there hasn't related code changes. This is typically caused by the database loads failing - how are you hosting the site?

[Foxy7]

Can't remember where the database is, will confirm tonight when at home.

Note, i did see the Temp Target grey line on my work pc first thing this morning, but it disappeared immediately when the page refreshed. Suggests to me it's 14.2.6 rather than a database issue. Also, doesn't explain why NSClient works correctly, since the data must be getting to the database.

What i will try tonight is to roll back to 14.2.5 and see if that works, without touching the database.

[Foxy7]

This is strange and i didn't notice it this morning, but i can see the Temp Target at the bottom of the screen, it must be a conversion issue as the grey line should be in the top graph. Note, this doesn't correct even if i change the units in the burger bar settings menu.

Just looking through the release notes releases, my feeling it's related to this change:

#7273

[Foxy7]

Having reversed this commit #7273 and reloaded i see the Temp Target correctly rendered now:

fwiw my change Foxy7@b905985

from my wife's NS

Before:

and After changing the line back

[Foxy7]

and same change worked for my kid's page:

after:

[emmatovar27]

@Foxy7 I'm using AAPS dev-f and my temp target looks like yours!

The first one was at 120 mg/dl the second one at 85 mg/dl

[sulkaharo]

Right - which version of AAPS are you using? What are the unit settings across your systems? Nightscout uses mg/dl by default, so nothing should be converted to mmol.

[sulkaharo]

Can you load a piece of sample data from /api/v1/treatments.json on your Nightscout that includes a temp basal that's affected?

[Foxy7]

@sulkaharo thanks for looking at this.

I'm using two different AAPS set ups using the AIMI plugin, this TT issue has only appeared since Saturday when updating to 14.2.6 and using that new change to NS. Have previously used openaps and multiple versions of AAPS with no issues.

My kid is running off a base of AAPS Master and my wife is runing off AAPS Dev at commit nightscout/AndroidAPS@82fb85c.

Using mmol/l across all NS and AAPS set ups.

This is today's morning temp target for my kid (Master AAPS), which is the same as the one from yday that didn't render correctly:

  {
    "_id": "63bd1a73496fb00004d1ba19",
    "eventType": "Temporary Target",
    "duration": 150,
    "durationInMilliseconds": 9000000,
    "isValid": true,
    "created_at": "2023-01-10T07:57:14.000Z",
    "timestamp": 1673337434000,
    "enteredBy": "AndroidAPS",
    "reason": "Activity",
    "targetBottom": 9.509509509499999,
    "targetTop": 9.509509509499999,
    "units": "mmol",
    "mills": 1673337434000,
    "carbs": null,
    "insulin": null
  },

Today's NS view looks good (edit for clarity; this is following removing the tt commit as above).

[olorinmaia]

Experiencing same issue on my Nightscout both in browser on my PC and android phone. Caretakers at school use temp-targets alot and they are really missing the possibility to easily see if there is a temp target or not in Nightscout. Attaching screenshot. Im using ns.10be.de. Is there something I can do or those hosting my Nightscout to fix this? Using latest AAPS master version and latest Nightscout master version.

[Foxy7]

@olorinmaia for the time being you can sync off my version, which is 14.2.6 except for the one change that is causing me the issue.

https://github.com/Foxy7/cgm-remote-monitor

for info, this is the change Foxy7@b905985 so you could just copy that to your NS repo if you prefer/easier.

[olorinmaia]

@olorinmaia for the time being you can sync off my version, which is 14.2.6 except for the one change that is causing me the issue.

https://github.com/Foxy7/cgm-remote-monitor

for info, this is the change Foxy7@b905985 so you could just copy that to your NS repo if you prefer/easier.

Thank you very much, thanks to this codechange it is now working for us and all other customers @ ns.10be.de :)

[sulkaharo]

Ah right, read the full code and there's a clear bug in that merge the people reviewing the code should have spotted. PR for the fix here: #7825

[Foxy7]

Thanks for investigating. i'll try this out tonight. #7825

[Foxy7]

Ah right, read the full code and there's a clear bug in that merge the people reviewing the code should have spotted. PR for the fix here: #7825

This fix looks good, works for me. Thanks.