-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redux with a "P" option does not return P-groups for two-field or three-field alleles #230
Comments
Thanks Giovanni for the detailed examples. I'll take a look at what's causing the difference. |
Hello @gbiagini, Just added the fix for P group mapping. Could you test it on your code ?
|
I tested the same alleles listed above with the same results. Maybe I'm missing something about getting the updated code? I tried installing py-ard from the standard I also tried reinstalling the IMGT database for version 3.52.0, but that didn't seem to change anything either. I tested both the Python module and CLI. Results of the CLI pasted below. |
It gives a correct answer on mine.
It's not published yet(hopefully soon) so you can't do Can you run
|
I got it working just now! Instead of forcing a re-install of the database through py-ard, I uninstalled py-ard again, deleted the entire cache in the Now "B*07:02" reduces to "B*07:02P". Previously, I was forcing a re-install of the database after uninstalling and reinstalling py-ard. A clean install may have been what fixed the inconsistency on my end, can't say for sure. |
Thanks for all the help @pbashyal-nmdp! |
Thanks for testing it and reporting the issue. It'll be part of |
When supplying a two-field allele to
ard.redux()
with the"P"
option, the allele name is generally returned instead of the P-group.This may primarily affect alleles with additional four-field variants.
For example,
ard.redux("B*07:02","P")
returnsB*07:02
(as doesard.redux("B*07:02:01","P")
), whileard.redux("B*07:02:01:01","P")
returnsB*07:02P
.Similarly,
ard.redux("DRB1*01:01","P")
returnsDRB1*01:01
(as doesard.redux("DRB1*01:01:01","P")
), whileard.redux("DRB1*01:01:01:01","P")
returnsDRB1*01:01P
.For an example of an allele without a four-field variant that behaves normally,
ard.redux("B*15:14","P")
returnsB*15:14P
, as expected.The expected behavior is that
ard.redux()
would return the same P-group for the two-field, three-field, and four-field equivalents of an allele.The addition of P-groups to
ard.redux()
is very helpful and I thank you for this tool and for your time. I'm happy to aid in debugging if desired.The text was updated successfully, but these errors were encountered: