-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Jenkins OAuth Application to nodejs (from rvagg) #687
Comments
Adding |
Couple of points brought up in the meeting.
Overall no-one had any particular concerns, so @rvagg does this make sense? |
Fine by me, it was done under my name because nodejs is an org, not a user, but if this is possible then 👍 |
OK, so it's possible to transfer to an org, the next question is permission. I don't know who gets access to the secret on this in the org, and we have a lot of org members. Instead of trying to find a doc (I can't so far), how about we test. I've made a new OAuth app for the nodejs org, can you all report whether you can see this or not? https://github.com/organizations/nodejs/settings/applications/517086 |
There's a second app btw, the Node.js Release Jenkins one |
@rvagg I believe that it's only the owner of the org who has full permissions |
I can't see it |
OK, well that's no good, since @gibfahn isn't even an org owner, we don't really want that key to be leaked |
To clarify, I am not able to see it, which suggests to me that it's only org owners who can. |
I can see it. |
Came up again today onboarding @BridgeAR. Not a big deal, but don't want this to be forgotten about. kthxbai |
Well that was much easier than I thought, nothing needed to change on the Jenkins end, just needed to do the transfer on the GitHub side and didn't need to touch Jenkins. So all done! |
I noticed that the ci.nodejs.org Jenkins Auth plugin is still owned by @rvagg. It would be good if we could transfer it to the Node.js org so it looks more official.
Apparently you go Setting->Oauth->Transfer and then specify nodejs (cc/ @gdams who's done it before).
The text was updated successfully, but these errors were encountered: