Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Jenkins OAuth Application to nodejs (from rvagg) #687

Closed
gibfahn opened this issue Apr 18, 2017 · 13 comments
Closed

Transfer Jenkins OAuth Application to nodejs (from rvagg) #687

gibfahn opened this issue Apr 18, 2017 · 13 comments

Comments

@gibfahn
Copy link
Member

gibfahn commented Apr 18, 2017

I noticed that the ci.nodejs.org Jenkins Auth plugin is still owned by @rvagg. It would be good if we could transfer it to the Node.js org so it looks more official.

image

Apparently you go Setting->Oauth->Transfer and then specify nodejs (cc/ @gdams who's done it before).

@gibfahn
Copy link
Member Author

gibfahn commented Apr 18, 2017

Adding wg-agenda to check that this is okay in the meeting.

@gibfahn gibfahn changed the title Transfer OAuth Application to nodejs (from rvagg) Transfer Jenkins OAuth Application to nodejs (from rvagg) Apr 18, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Apr 18, 2017

Couple of points brought up in the meeting.

  • Is it an easy process?
    • As I noted above, it should be a two minute change.
  • Will there be any loss of data from moving it?
    • There shouldn't be, and in any case if we lose the cache that just means everyone has to click the button again, which isn't the end of the world.
  • Does the app know any sensitive information that we wouldn't want to be accessible to nodejs owners?
    • I think it just gets read access to email addresses, and org/team membership, so that shouldn't be too worrying.

Overall no-one had any particular concerns, so @rvagg does this make sense?

@rvagg
Copy link
Member

rvagg commented Apr 19, 2017

Fine by me, it was done under my name because nodejs is an org, not a user, but if this is possible then 👍

@rvagg
Copy link
Member

rvagg commented Apr 19, 2017

screenshot 2017-04-19 12 37 09

OK, so it's possible to transfer to an org, the next question is permission. I don't know who gets access to the secret on this in the org, and we have a lot of org members. Instead of trying to find a doc (I can't so far), how about we test. I've made a new OAuth app for the nodejs org, can you all report whether you can see this or not? https://github.com/organizations/nodejs/settings/applications/517086

@rvagg
Copy link
Member

rvagg commented Apr 19, 2017

There's a second app btw, the Node.js Release Jenkins one

@gdams
Copy link
Member

gdams commented Apr 19, 2017

@rvagg I believe that it's only the owner of the org who has full permissions

@gibfahn
Copy link
Member Author

gibfahn commented Apr 19, 2017

can you all report whether you can see this or not?

I can't see it

@rvagg
Copy link
Member

rvagg commented Apr 21, 2017

OK, well that's no good, since @gibfahn isn't even an org owner, we don't really want that key to be leaked

@gibfahn
Copy link
Member Author

gibfahn commented Apr 21, 2017

OK, well that's no good, since @gibfahn isn't even an org owner, we don't really want that key to be leaked

To clarify, I am not able to see it, which suggests to me that it's only org owners who can.

image

@mhdawson
Copy link
Member

I can see it.

@gibfahn
Copy link
Member Author

gibfahn commented Jun 30, 2017

ping @rvagg , given that I think we've established that only org owners can see it, maybe time to make the move?

cc/ @Trott

@Trott
Copy link
Member

Trott commented Aug 16, 2017

Came up again today onboarding @BridgeAR. Not a big deal, but don't want this to be forgotten about. kthxbai

@rvagg
Copy link
Member

rvagg commented Aug 16, 2017

Well that was much easier than I thought, nothing needed to change on the Jenkins end, just needed to do the transfer on the GitHub side and didn't need to touch Jenkins. So all done!

@rvagg rvagg closed this as completed Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants