Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins CI #342

Closed
gdams opened this issue Jan 31, 2017 · 5 comments
Closed

Jenkins CI #342

gdams opened this issue Jan 31, 2017 · 5 comments
Labels

Comments

@gdams
Copy link
Member

gdams commented Jan 31, 2017

We should look into creating a CI test for citgm on jenkins so that we can run npm-test on all of our platforms. Node core are already doing this and are exploring whether they can use the GitHub bot to automatically kick off the jobs. This would also hopefully prevent some of the flakiness that we are seeing with Travis

@gdams
Copy link
Member Author

gdams commented Jan 31, 2017

CC @nodejs/citgm

@gdams gdams added the CI label Jan 31, 2017
@MylesBorins
Copy link
Contributor

@gdams technically we could just run the citgm job
¯\_(ツ)_/¯

can you point me towards the thread where they are talking about doing this for core. AFAIK this was not done for security and resource reasons

@gdams
Copy link
Member Author

gdams commented Jan 31, 2017

We would have to modify the job to make that work wouldn't we?

nodejs/github-bot#82 The key thing is that a module admin must type safe to test or something before the bot runs the CI

@gdams
Copy link
Member Author

gdams commented Feb 6, 2017

nodejs/github-bot#123

@gdams
Copy link
Member Author

gdams commented Feb 27, 2017

closing as #358 is more relevant

@gdams gdams closed this as completed Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants