From 9bc02ff89a41735db50582c30fc23eb7ea96ff47 Mon Sep 17 00:00:00 2001 From: Gibson Fahnestock Date: Wed, 14 Feb 2018 09:23:59 +0000 Subject: [PATCH] doc: note that linting is required in releases.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/node/pull/18769 PR-URL: https://github.com/nodejs/node/pull/18776 Refs: https://github.com/nodejs/node/pull/18769 Reviewed-By: Matheus Marchini Reviewed-By: Ruben Bridgewater Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: James M Snell --- doc/releases.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/releases.md b/doc/releases.md index 0b44edde55935a..06dbf47bc7d227 100644 --- a/doc/releases.md +++ b/doc/releases.md @@ -269,6 +269,9 @@ Merge your release proposal branch into the stable branch that you are releasing Cherry-pick the release commit to `master`. After cherry-picking, edit `src/node_version.h` to ensure the version macros contain whatever values were previously on `master`. `NODE_VERSION_IS_RELEASE` should be `0`. +Run `make lint-md-build; make lint` before pushing to `master`, to make sure the +Changelog formatting passes the lint rules on `master`. + ### 12. Promote and Sign the Release Builds **It is important that the same individual who signed the release tag be the one to promote the builds as the SHASUMS256.txt file needs to be signed with the same GPG key!**