Skip to content

Commit d20b7bf

Browse files
danbevMylesBorins
authored andcommitted
src: use local isolate instead of args.GetIsolate
While stepping though SetupPromises I noticed that the environments Isolate is used but not when creating the string "_setupPromises". Is there a reason for using args.GetIsolate() instead of using the environments isolate? I see that GetIsolate() is an inline call, but could there be situations where it returns a different Isolate? If not perhaps using the local isolate variable would be a litte clearer. PR-URL: #14768 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 9f33025 commit d20b7bf

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1230,7 +1230,7 @@ void SetupPromises(const FunctionCallbackInfo<Value>& args) {
12301230

12311231
env->process_object()->Delete(
12321232
env->context(),
1233-
FIXED_ONE_BYTE_STRING(args.GetIsolate(), "_setupPromises")).FromJust();
1233+
FIXED_ONE_BYTE_STRING(isolate, "_setupPromises")).FromJust();
12341234
}
12351235

12361236

0 commit comments

Comments
 (0)