New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2 compat missing writableFinished #29230

Open

ronag opened this issue Aug 20, 2019 · 1 comment

Labels

http2

Member

ronag commented Aug 20, 2019 •

edited

Loading

http2 compat is missing writableFinished for OutgoingMessage.

I tried fixing this myself but the whole finished flow for http2 compat confuses me.

finished seems to be looking at a lot of different stuff (e.g. what does abort have to do with finish?).
'finish' is emitted on stream.on('close', ...).
Sometimes we listen to this.on('finish', ...) and sometimes stream.on('finish', ...).

I think someone with a clearer understanding needs to look at this.

The text was updated successfully, but these errors were encountered:

Member Author

ronag commented Aug 20, 2019

Slightly related #24347

Fishrock123 added the http2 label

sogaani mentioned this issue

The differences between http2 compatibility API and http[s] #29829

Open

32 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment