Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8-fast-api-calls.h is no longer in headers archive #43619

Open
kriszyp opened this issue Jun 8, 2021 · 3 comments
Open

v8-fast-api-calls.h is no longer in headers archive #43619

kriszyp opened this issue Jun 8, 2021 · 3 comments

Comments

@kriszyp
Copy link

kriszyp commented Jun 8, 2021

v8-fast-api-calls.h was included in the header archive for 15.x (and 14.x?), but it is no longer included as of v16.0: https://nodejs.org/download/release/v16.0.0/node-v16.0.0-headers.tar.gz
It would be nice to have this back so that native add-ons could properly use (and compile with) the new V8 fast call api (like Node does with process.hrtime).

@richardlau
Copy link
Member

This was a deliberate change under #37570 so cc @targos.

@kriszyp
Copy link
Author

kriszyp commented Jun 8, 2021

I assumed it was deliberate. Based on the thread, it sounds like they were on the fence about the fast api calls header, but it was considered a little bit too unstable. And this is fine, I've included a copy of the headers file for now in my package, but hopefully it would be a priority to include the fast api calls header soon, as it stabilizes.

@targos
Copy link
Member

targos commented Jun 8, 2021

Only people from the V8 team can tell us when they think it's stable. FWIW I had to adapt Node.js to a breaking change less than a month ago: 4723ff1

@BethGriggs BethGriggs transferred this issue from nodejs/Release Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants