Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use biomejs instead of prettier and eslint #132

Closed
AugustinMauroy opened this issue Aug 25, 2024 · 12 comments
Closed

use biomejs instead of prettier and eslint #132

AugustinMauroy opened this issue Aug 25, 2024 · 12 comments

Comments

@AugustinMauroy
Copy link
Member

On this project we have two tools to format and lint our code. But they're not the best performers.

One solution is to use biomejs which is a trainer and linter of code written in rust. It covers what prettier and eslint do on this project.

In addition the dev node_module size will be reduce:

  • eslint : 3.08 MB
  • prettier 7.7 MB
  • biome 152 kB
@flakey5
Copy link
Member

flakey5 commented Aug 25, 2024

Are there plans to switch the website and api docs repos to biomejs as well?

@flakey5
Copy link
Member

flakey5 commented Aug 25, 2024

I think we should be using as many of the same tools across projects that we can just to make switching between them as easy as possible.

I'd be in favor of using it here as a trial run though if we're looking at using it in the website and api docs repos

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Aug 26, 2024

Honestly, I saw that Amaro was using Biome, so I thought that was cool. I then looked at comparisons (dep size, performance, compatibility, etc.), which is why I'm offering it on this repo. Yes api-doc-tooling could also use biome.

But for nodejs.org, I have already looked it is not possible it still lacks support for markdown by biome. But yes if not for nodejs.org we could use biome instead of Eslint, prettier and styleLint.

As you say, there should be uniformity in the tools we use. So here's a list of repo's that could also receive biome

Note

On nodejs org we have a lintting team that we can ping

@flakey5
Copy link
Member

flakey5 commented Aug 31, 2024

cc @nodejs/web-infra wdyt?

@flakey5
Copy link
Member

flakey5 commented Aug 31, 2024

So here's a list of repo's that could also receive biome

I think their usage should be discussed in other issues with the teams that maintain them since they don't fall under the website scope of things

@ovflowd
Copy link
Member

ovflowd commented Sep 1, 2024

cc @nodejs/web-infra wdyt?

+1

@flakey5
Copy link
Member

flakey5 commented Sep 5, 2024

Think we can move forward with this then

@bmuenzenmeyer
Copy link
Contributor

I was going to mention that this feels like chasing "the new-thing"...and it felt oddly reminiscent to how rome was supposed to take off, and then I discovered that its the same people/project.

I'm ambivalent - but also wanted to mention that eslint is an OpenJS Foundation project.

@AugustinMauroy
Copy link
Member Author

Brian is right on this point.

Maybe we could get an opinion from TSC or team lint?

@ovflowd
Copy link
Member

ovflowd commented Sep 6, 2024

Brian is right on this point.

Maybe we could get an opinion from TSC or team lint?

I don't think the TSC would wage in here. It's not up to them. It's not a Node technical decision.

I'm fine staying with ESlint too. Let's keep it as it is for the meantime, as things are working, and revisit this in the future, wdyt @flakey5?

@flakey5
Copy link
Member

flakey5 commented Sep 6, 2024

I'm fine staying with ESlint too

+1

@ovflowd
Copy link
Member

ovflowd commented Sep 10, 2024

I'll close this for the time being then.

@ovflowd ovflowd closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants