Skip to content

Commit 2e6bb3e

Browse files
AgentEnderFrozenPandaz
authored andcommitted
fix(core): do not warn about custom tasks runners when explicitly usi… (#29669)
…ng default<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 104f06c)
1 parent fcb1a3b commit 2e6bb3e

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

nx.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@
245245
"nxCloudId": "62d013ea0852fe0a2df74438",
246246
"nxCloudUrl": "https://staging.nx.app",
247247
"parallel": 1,
248-
"bust": 1,
248+
"bust": 2,
249249
"defaultBase": "master",
250250
"conformance": {
251251
"rules": [

packages/nx/src/tasks-runner/run-command.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -912,8 +912,12 @@ export function getRunnerOptions(
912912

913913
return result;
914914
}
915+
915916
function isCustomRunnerPath(modulePath: string) {
916-
return !['nx-cloud', '@nrwl/nx-cloud', defaultTasksRunnerPath].includes(
917-
modulePath
918-
);
917+
return ![
918+
'nx-cloud',
919+
'@nrwl/nx-cloud',
920+
'nx/tasks-runners/default',
921+
defaultTasksRunnerPath,
922+
].includes(modulePath);
919923
}

0 commit comments

Comments
 (0)