Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase deps versions are not pinned #10

Open
emanuelb opened this issue Jan 28, 2023 · 0 comments
Open

firebase deps versions are not pinned #10

emanuelb opened this issue Jan 28, 2023 · 0 comments

Comments

@emanuelb
Copy link

emanuelb commented Jan 28, 2023

The firebase dependencies firebase-crashlytics-ktx and firebase-crashlytics-ndk don't use a static version like in dependency firebase-bom:30.0.1 and other deps in ./configs/dependencies.gradle

firebaseCrashlytics : "com.google.firebase:firebase-crashlytics-ktx",
firebaseNdkCrashlytics: "com.google.firebase:firebase-crashlytics-ndk",

Because this dependencies versions are not pinned: (fix is to add :versionNumber to them like its done for other dependencies in this file such as firebase-bom)

comparing built apk to apk from googleplay may result in diff in libcrashlytics*.so files in case by the time of local build there will be newer releases then the one used in upstream build

@emanuelb emanuelb changed the title firbase firebase deps versions are not pinned Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant