Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapsigner does not support taproot (yet) #9

Open
scgbckbone opened this issue Jul 24, 2022 · 2 comments
Open

Tapsigner does not support taproot (yet) #9

scgbckbone opened this issue Jul 24, 2022 · 2 comments

Comments

@scgbckbone
Copy link

Just tested Tapsigner (1.0.0) with nunchuck on android 11. Works great!!!

One thing that I think is bad from UX perspective is the ability to add tapsigner nfc key to taproot wallet. Tapsigner is not able to sign taproot inputs (no schnorr support yet). Showing just warning, to check compatibility of your HW devices is imho not enough. Users do stupid things all the time.

Coins that user sends to taproot wallet with nfc tapsigner key are effectively locked. When attempting to spend taproot utxo nunchuck flashes that transaction signed successfully but nothing is signed and button to broadcast transaction does not appear.

It would be better, if user wants to add tapsigner to taproot wallet, error should be thrown describing the limitations.

@hugohn
Copy link
Contributor

hugohn commented Jul 24, 2022

Yup Coinkite does not support Taproot signing yet. Showing an error is a good suggestion. Thanksl @scgbckbone

@scgbckbone
Copy link
Author

same applies to Coldcard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants