Does debug extension need the controller?

[SeriousKen]

october/modules/cms/twig/DebugExtension.php

Lines 54 to 61 in 8ba63dd

	/**
	* Creates the extension instance.
	* @param \Cms\Classes\Controller $controller The CMS controller object.
	*/
	public function __construct(Controller $controller)
	{
	$this->controller = $controller;
	}

The debug extension requires the controller in its constructor but doesn't reference it anywhere. Should this be refactored out?

[LukeTowers]

@SeriousKen is it causing any problems to have it there?

[SeriousKen]

@LukeTowers It's not causing a problem as such, but I noticed it when looking into this issue in the Pages plugin. The Twig environment is newed up in the CmsCompoundObject without the DebugExtension, but you can't new up the DebugExtension without a controller instance, which the CmsCompoundObject doesn't have access to.

Also, in the interests of clean code, anything that is redundant should be removed.

[Samuell1]

@LukeTowers

[bennothommo]

@Samuell1 I'll leave this open. It's something that may need to be looked into in the future.

[Samuell1]

@bennothommo it was just ping if this is actual, i can then do PR to remove it, because there is still label response needed.

[bennothommo]

@Samuell1 by all means, have a go at it if you want to :). Probably is worth having a look at.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 30 days. If this issue is still relevant or you would like to see action on it, please respond and we will get the ball rolling.