From 00e004ffccde364301685a59c743282e0db382db Mon Sep 17 00:00:00 2001 From: olzzon Date: Thu, 25 Mar 2021 10:11:30 +0100 Subject: [PATCH] fix: migration should write settings in sync mode to prevent async loading of old settings --- server/utils/migrations.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/server/utils/migrations.ts b/server/utils/migrations.ts index 380402ef..a4774daf 100644 --- a/server/utils/migrations.ts +++ b/server/utils/migrations.ts @@ -67,6 +67,17 @@ const migrate45to46 = (currentSettings: ISettings): ISettings => { ) }) currentSettings.sisyfosVersion = version - saveSettings(currentSettings) + delete currentSettings.customPages + fs.writeFileSync( + path.resolve('storage', 'settings.json'), + JSON.stringify(currentSettings), + 'utf8', + (error: any) => { + logger.error( + 'Migration failed - error writing settings.json file: ', + error + ) + } + ) return currentSettings }