-
Notifications
You must be signed in to change notification settings - Fork 299
oni 0.3.9 not working with nvim 0.3.3 #2706
Comments
Can confirm not working after upgrade to neovim 0.3.2 too. |
I had the same issue today on MacOS after updating to I don't think my solution will help you, as I am on a different OS, but it might help other Mac OS users. Following #2590, I had been running Oni with the Commenting out the key in the |
I can confirm, that explicitly setting value of "debug.neovimPath" to nvim version 0.3.0 allows me to use nvim 0.3 3. It is just an workaround, the issue that oni does not work with the latest nvim version still persist. |
To keep things together (so we don't duplicate work). There's another issue on this #2704. tldr; A call to the neovim API is not completing |
same issue on MacOS |
Archlinux too
|
neovim/neovim@4da5cb3 changed the behavior of the command line argument A pretty simple patch: losinggeneration/oni@da86cba is all that's needed to get Oni working again with nvim >= 0.3.2 |
Updated the AUR package to depend on |
OK, for everyone having this problem (i.e., using NeoVIM versions >= 0.3.2), there is a very simple solution without reinstalling anything or downgrading nvim, or patching/rebuilding oni, or anything like that. I don't know why it was so difficult for the people who figured this out to post the most basic instructions for the most simple of fixes? This is for Linux (assuming Oni was installed in /opt/Oni), but other OS's are similar, just find the resources/app/lib/browser/vendor.bundle.js file, wherever it lies on your filesystem (probably ...\resources\app\lib\browser\vendor.bundle.js on windows. Replace ... with where the oni stuff lives). The solution to this is as simple as, editing the file /opt/Oni/resources/app/lib/browser/vendor.bundle.js (may need to use sudo, if it is owned by root): Note: Don't include the ellipses (plural of ellipsis, as in ...) in your search - just the phrase highlighted in gray, above (it should start with a comma and end with a quote). The ellipses are just being used as placeholders for the omitted start/end text of that horrendously long line, to keep things simple. And insert Voila, problem solved in 30 seconds or less! |
@mgoldshteyn something like this for POSIX systems. sed 's/"--embed",/"--embed","--headless",/' resources/app/lib/browser/vendor.bundle.js > tmp.js
mv tmp.js resources/app/lib/browser/vendor.bundle.js |
Just make sure you |
I specifically avoided that because in-place is handled differently between OS X & Linux (last I checked) I think something like |
Hello, By modifying vendor.bundle.js as explained by @mgoldshteyn, with no other custom change, it worked for me, BUT only if I launch it from the terminal. I am new to this software and I encountered other bugs which I don't know if are related to this 'hack'. So as for editing files it seem it's working but I couldn't say it doesn't cause errors/bug somewhere else. |
I wish they fixed this in the next update, otherwise it would be annoying to have to do this on every new installation or update. |
I have no idea, if there is any next update to happen as there is ongoing work on onivim2 |
Oni Version: 0.3.9
Neovim Version (Linux only): 0.3.3
Operating System: Debian Stretch
Issue:
When nvim 0.3.3 installed, oni starts very slowly and then does not function. It is even not possible to get the ":" prompt.
Expected behavior:
oni shall work with latest released nvim version.
Actual behavior:
For nvim version 0.3.3 oni does not work.
Steps to reproduce:
Install nvim 0.3.3 (I used nvim.appimage).
Have oni 0.3.9 installed (used deb package)
In default configuration (variable
ONI_NEOVIM_PATH
not set), oni starts but it takes few seconds more, then it is not possible to open a file or open the ":" prompt.When
ONI_NEOVIM_PATH
is set to older version of nvim (I have version 0.3.0), oni works well.The text was updated successfully, but these errors were encountered: