Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupdate broke in 3.5.0 #1699

Closed
sarathms opened this issue Jun 24, 2021 · 0 comments · Fixed by ooni/probe-desktop#232
Closed

Autoupdate broke in 3.5.0 #1699

sarathms opened this issue Jun 24, 2021 · 0 comments · Fixed by ooni/probe-desktop#232
Assignees
Labels
bug Something isn't working correctly ooni/probe-desktop priority/high Important issue that needs attention soon

Comments

@sarathms
Copy link

A recently applied fix for #1318 has introduced a bug in the autoupdate process which now prevents the app from automatically updating from 3.5.0 or 3.5.1.

From the logs:

[2021-06-24 00:08:13.360] [info]  Found version 3.5.1 (url: OONI-Probe-3.5.1-mac.zip,
OONI-Probe-3.5.1.dmg)
[2021-06-24 00:08:13.669] [info]  A new update is available. Downloading now...
[2021-06-24 00:08:13.676] [info]  Update not available

Risk Mitigation:

We have unpublished the affected versions 3.5.0 and 3.5.1 from Github releases to minimize the number of users automatically upgrading to those versions. Users who are still running 3.4.0 should be able to update directly to the next version that will have a fix for this bug.

Other steps to address this kind of an issue in future:

  • Automate testing the auto-update feature in CI
  • Have a mechanism to show notices in the app on startup to be able to help out users stuck in unupgradable versions.
@sarathms sarathms added bug Something isn't working correctly priority/high Important issue that needs attention soon ooni/probe-desktop labels Jun 24, 2021
@sarathms sarathms added this to the Sprint 42 - Kujira milestone Jun 24, 2021
@sarathms sarathms self-assigned this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly ooni/probe-desktop priority/high Important issue that needs attention soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant