Skip to content

Commit 93dde1d

Browse files
chore: expose get value for metadata (#468)
expose get value for metadata Signed-off-by: Kavindu Dodanduwa <[email protected]> Co-authored-by: Justin Abrahms <[email protected]>
1 parent 3946211 commit 93dde1d

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

src/main/java/dev/openfeature/sdk/FlagMetadata.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,10 @@ public Boolean getBoolean(final String key) {
7777
return getValue(key, Boolean.class);
7878
}
7979

80-
private <T> T getValue(final String key, final Class<T> type) {
80+
/**
81+
* Generic value retrieval for the given key.
82+
*/
83+
public <T> T getValue(final String key, final Class<T> type) {
8184
final Object o = metadata.get(key);
8285

8386
if (o == null) {

src/test/java/dev/openfeature/sdk/FlagMetadataTest.java

+12-1
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,22 @@ public void builder_validation() {
2222

2323
// then
2424
assertThat(flagMetadata.getString("string")).isEqualTo("string");
25+
assertThat(flagMetadata.getValue("string", String.class)).isEqualTo("string");
26+
2527
assertThat(flagMetadata.getInteger("integer")).isEqualTo(1);
28+
assertThat(flagMetadata.getValue("integer", Integer.class)).isEqualTo(1);
29+
2630
assertThat(flagMetadata.getLong("long")).isEqualTo(1L);
31+
assertThat(flagMetadata.getValue("long", Long.class)).isEqualTo(1L);
32+
2733
assertThat(flagMetadata.getFloat("float")).isEqualTo(1.5f);
34+
assertThat(flagMetadata.getValue("float", Float.class)).isEqualTo(1.5f);
35+
2836
assertThat(flagMetadata.getDouble("double")).isEqualTo(Double.MAX_VALUE);
37+
assertThat(flagMetadata.getValue("double", Double.class)).isEqualTo(Double.MAX_VALUE);
38+
2939
assertThat(flagMetadata.getBoolean("boolean")).isEqualTo(Boolean.FALSE);
40+
assertThat(flagMetadata.getValue("boolean", Boolean.class)).isEqualTo(Boolean.FALSE);
3041
}
3142

3243
@Test
@@ -38,7 +49,7 @@ public void value_type_validation() {
3849
.build();
3950

4051
// then
41-
assertThat(flagMetadata.getBoolean("string")).isNull();
52+
assertThat(flagMetadata.getBoolean("string")).isNull();
4253
}
4354

4455
@Test

0 commit comments

Comments
 (0)