Skip to content

Commit a5c93ac

Browse files
toddbaertthisthat
andauthored
chore: rename integration tests e2e (#417)
* chore: rename integration tests e2e Signed-off-by: Todd Baert <[email protected]> * Update pom.xml Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Todd Baert <[email protected]> --------- Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Giovanni Liva <[email protected]>
1 parent 19415ed commit a5c93ac

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

.github/workflows/pullrequest.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ jobs:
3838
restore-keys: |
3939
${{ runner.os }}-maven-
4040
41-
- name: Build with Maven
42-
run: mvn --batch-mode --update-snapshots verify -P integration-test
41+
- name: Verify with Maven
42+
run: mvn --batch-mode --update-snapshots verify -P e2e-test
4343

4444
- name: Upload coverage to Codecov
4545
uses: codecov/codecov-action@5bf250470ea3e4bf9456e73127015eb78ce4c280

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,16 @@ If you think we might be out of date with the spec, you can check that by invoki
1616

1717
If you're adding tests to cover something in the spec, use the `@Specification` annotation like you see throughout the test suites.
1818

19-
## Integration tests
19+
## End-to-End Tests
2020

21-
The continuous integration runs a set of [gherkin integration tests](https://github.com/open-feature/test-harness/blob/main/features/evaluation.feature) using [`flagd`](https://github.com/open-feature/flagd). These tests do not run with the default maven profile. If you'd like to run them locally, you can start the flagd testbed with
21+
The continuous integration runs a set of [gherkin e2e tests](https://github.com/open-feature/test-harness/blob/main/features/evaluation.feature) using [`flagd`](https://github.com/open-feature/flagd). These tests do not run with the default maven profile. If you'd like to run them locally, you can start the flagd testbed with
2222

2323
```
2424
docker run -p 8013:8013 ghcr.io/open-feature/flagd-testbed:latest
2525
```
2626
and then run
2727
```
28-
mvn test -P integration-test
28+
mvn test -P e2e-test
2929
```
3030

3131
## Releasing

pom.xml

+5-5
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<maven.compiler.source>1.8</maven.compiler.source>
1212
<maven.compiler.target>${maven.compiler.source}</maven.compiler.target>
1313
<junit.jupiter.version>5.9.3</junit.jupiter.version>
14-
<!-- exclusion expression for integration tests -->
15-
<testExclusions>**/integration/*.java</testExclusions>
14+
<!-- exclusion expression for e2e tests -->
15+
<testExclusions>**/e2e/*.java</testExclusions>
1616
<module-name>${groupId}.${artifactId}</module-name>
1717
</properties>
1818

@@ -495,10 +495,10 @@
495495

496496
<profiles>
497497
<profile>
498-
<!-- this profile handles running the flagd integration tests -->
499-
<id>integration-test</id>
498+
<!-- this profile handles running the flagd e2e tests -->
499+
<id>e2e-test</id>
500500
<properties>
501-
<!-- run the integration tests by clearing the exclusions -->
501+
<!-- run the e2e tests by clearing the exclusions -->
502502
<testExclusions/>
503503
</properties>
504504
<build>

src/test/java/dev/openfeature/sdk/integration/RunCucumberTest.java src/test/java/dev/openfeature/sdk/e2e/RunCucumberTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.openfeature.sdk.integration;
1+
package dev.openfeature.sdk.e2e;
22

33
import org.junit.platform.suite.api.ConfigurationParameter;
44
import org.junit.platform.suite.api.IncludeEngines;

src/test/java/dev/openfeature/sdk/integration/StepDefinitions.java src/test/java/dev/openfeature/sdk/e2e/StepDefinitions.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.openfeature.sdk.integration;
1+
package dev.openfeature.sdk.e2e;
22

33
import dev.openfeature.contrib.providers.flagd.FlagdProvider;
44
import dev.openfeature.sdk.Client;

0 commit comments

Comments
 (0)