Skip to content

Commit b5c1ab5

Browse files
committed
fixup: shorten javadoc links, shutdown tasks, use methods refs
Signed-off-by: Todd Baert <[email protected]>
1 parent d8ea14b commit b5c1ab5

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

src/main/java/dev/openfeature/sdk/EventProvider.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ void attach(TriConsumer<EventProvider, ProviderEvent, ProviderEventDetails> onEm
2929
}
3030

3131
/**
32-
* Emit the specified {@link dev.openfeature.sdk.ProviderEvent}.
32+
* Emit the specified {@link ProviderEvent}.
3333
*
3434
* @param event The event type
3535
* @param details The details of the event
@@ -41,7 +41,7 @@ public void emit(ProviderEvent event, ProviderEventDetails details) {
4141
}
4242

4343
/**
44-
* Emit a {@link dev.openfeature.sdk.ProviderEvent#PROVIDER_READY} event.
44+
* Emit a {@link ProviderEvent#PROVIDER_READY} event.
4545
* Shorthand for {@link #emit(ProviderEvent, ProviderEventDetails)}
4646
*
4747
* @param details The details of the event
@@ -52,7 +52,7 @@ public void emitProviderReady(ProviderEventDetails details) {
5252

5353
/**
5454
* Emit a
55-
* {@link dev.openfeature.sdk.ProviderEvent#PROVIDER_CONFIGURATION_CHANGED}
55+
* {@link ProviderEvent#PROVIDER_CONFIGURATION_CHANGED}
5656
* event. Shorthand for {@link #emit(ProviderEvent, ProviderEventDetails)}
5757
*
5858
* @param details The details of the event
@@ -62,7 +62,7 @@ public void emitProviderConfigurationChanged(ProviderEventDetails details) {
6262
}
6363

6464
/**
65-
* Emit a {@link dev.openfeature.sdk.ProviderEvent#PROVIDER_STALE} event.
65+
* Emit a {@link ProviderEvent#PROVIDER_STALE} event.
6666
* Shorthand for {@link #emit(ProviderEvent, ProviderEventDetails)}
6767
*
6868
* @param details The details of the event
@@ -72,7 +72,7 @@ public void emitProviderStale(ProviderEventDetails details) {
7272
}
7373

7474
/**
75-
* Emit a {@link dev.openfeature.sdk.ProviderEvent#PROVIDER_ERROR} event.
75+
* Emit a {@link ProviderEvent#PROVIDER_ERROR} event.
7676
* Shorthand for {@link #emit(ProviderEvent, ProviderEventDetails)}
7777
*
7878
* @param details The details of the event

src/main/java/dev/openfeature/sdk/EventSupport.java

+4
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ public void runHandler(Consumer<EventDetails> handler, EventDetails eventDetails
8888
});
8989
}
9090

91+
public void shutdown() {
92+
taskExecutor.shutdown();
93+
}
94+
9195
static class HandlerStore {
9296

9397
private final Map<ProviderEvent, List<Consumer<EventDetails>>> handlerMap;

src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class OpenFeatureAPI implements EventHandling<OpenFeatureAPI> {
2424
private EvaluationContext evaluationContext;
2525
private final List<Hook> apiHooks;
2626
private ProviderRepository providerRepository = new ProviderRepository();
27-
private final EventSupport eventSupport = new EventSupport();
27+
private EventSupport eventSupport = new EventSupport();
2828

2929
protected OpenFeatureAPI() {
3030
apiHooks = new ArrayList<>();
@@ -119,7 +119,7 @@ public void setProvider(String clientName, FeatureProvider provider) {
119119
this::attachEventProvider,
120120
this::emitReady,
121121
this::detachEventProvider,
122-
this::emitError)
122+
this::emitError);
123123
}
124124
}
125125

@@ -192,7 +192,7 @@ public void clearHooks() {
192192

193193
public void shutdown() {
194194
providerRepository.shutdown();
195-
// TODO: shutdown events
195+
eventSupport.shutdown();
196196
}
197197

198198
/**
@@ -268,8 +268,9 @@ void addHandler(String clientName, ProviderEvent event, Consumer<EventDetails> h
268268
* This method is only here for testing as otherwise all tests after the API
269269
* shutdown test would fail.
270270
*/
271-
final void resetProviderRepository() {
271+
final void reset() {
272272
providerRepository = new ProviderRepository();
273+
eventSupport = new EventSupport();
273274
}
274275

275276
/**

src/test/java/dev/openfeature/sdk/ShutdownBehaviorSpecTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ void mustShutdownAllProvidersOnShuttingDownApi() {
110110
verify(namedProvider).shutdown();
111111
});
112112

113-
api.resetProviderRepository();
113+
api.reset();
114114
}
115115
}
116116
}

0 commit comments

Comments
 (0)