-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why axum always in dependency tree? #2665
Comments
Suggest you use cargo tree to figure out the dependency tree. IIRC tonic pulls in Axum for some stuff. I don't think there's something we can do in this project. |
@djc Thanks for your reply! AFAICS the dep to axum in tonic is optional: If you're sure that this issue should be resolved at the tonic repo, I'd create an issue there. But running cargo tree against tonic without any other features doesn't give axum:
|
I fount it: I depend on |
Theoretically, a client library should not depend on server-side framework. If so then we can figure out how to drop this dependency. |
#2666 should resolve this issue cc @cijothomas |
I'm trying to remove axum in the final dependency tree (and thus any binary that depends on opentelemetry) - fast/logforth#102
But it seems axum is always included.
IIUC opentelemetry-rust is only a client library that don't need such server-side dependency and I can see that our dependency to tonic is marked
default-features = false
.Why do we still get a dependency to axum in the end?
cc @djc
The text was updated successfully, but these errors were encountered: