New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obscpio containing zip file raises BadZipFile exception #87

Open

StefanBruens opened this issue Jan 1, 2024 · 0 comments

StefanBruens commented Jan 1, 2024

The zipfile.is_zipfile unfortunately misclassifies any file which has a zipfile end-of-central-directory header in its last 65kByte as a zipfile:

python/cpython#72680

This is often the case when one of the last files in the obscpio archive is a zip file, or any other file which contains a zip file.

The check should probably ignore any python exceptions, or at least also BadZipFile:

obs-service-set_version/set_version

Lines 249 to 252 in d4150d2

    
           except OSError: 
        
               # is_zipfile has often false positives and module is 
        
               # crashing on processing 
        
               pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment