Skip to content

Commit 0ab3d08

Browse files
committed
Let media type validator start with validator
Signed-off-by: Lei Jitang <[email protected]>
1 parent 3444e22 commit 0ab3d08

5 files changed

+17
-17
lines changed

schema/config_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ func TestConfig(t *testing.T) {
211211
},
212212
} {
213213
r := strings.NewReader(tt.config)
214-
err := schema.MediaTypeImageConfig.Validate(r)
214+
err := schema.ValidatorMediaTypeImageConfig.Validate(r)
215215

216216
if got := err != nil; tt.fail != got {
217217
t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)

schema/manifest_backwards_compatibility_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func TestBackwardsCompatibilityManifestList(t *testing.T) {
118118

119119
manifest := convertFormats(tt.manifest)
120120
r := strings.NewReader(manifest)
121-
err := schema.MediaTypeManifestList.Validate(r)
121+
err := schema.ValidatorMediaTypeManifestList.Validate(r)
122122

123123
if got := err != nil; tt.fail != got {
124124
t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)
@@ -181,7 +181,7 @@ func TestBackwardsCompatibilityManifest(t *testing.T) {
181181

182182
manifest := convertFormats(tt.manifest)
183183
r := strings.NewReader(manifest)
184-
err := schema.MediaTypeManifest.Validate(r)
184+
err := schema.ValidatorMediaTypeManifest.Validate(r)
185185

186186
if got := err != nil; tt.fail != got {
187187
t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)
@@ -221,7 +221,7 @@ func TestBackwardsCompatibilityConfig(t *testing.T) {
221221

222222
config := convertFormats(tt.config)
223223
r := strings.NewReader(config)
224-
err := schema.MediaTypeImageConfig.Validate(r)
224+
err := schema.ValidatorMediaTypeImageConfig.Validate(r)
225225

226226
if got := err != nil; tt.fail != got {
227227
t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)

schema/manifest_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ func TestManifest(t *testing.T) {
183183
},
184184
} {
185185
r := strings.NewReader(tt.manifest)
186-
err := schema.MediaTypeManifest.Validate(r)
186+
err := schema.ValidatorMediaTypeManifest.Validate(r)
187187

188188
if got := err != nil; tt.fail != got {
189189
t.Errorf("test %d: expected validation failure %t but got %t, err %v", i, tt.fail, got, err)

schema/schema.go

+11-11
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ import (
2222

2323
// Media types for the OCI image formats
2424
const (
25-
MediaTypeDescriptor Validator = v1.MediaTypeDescriptor
26-
MediaTypeManifest Validator = v1.MediaTypeImageManifest
27-
MediaTypeManifestList Validator = v1.MediaTypeImageManifestList
28-
MediaTypeImageConfig Validator = v1.MediaTypeImageConfig
29-
TypeImageLayout Validator = v1.ImageLayoutFile
30-
MediaTypeImageLayer unimplemented = v1.MediaTypeImageLayer
25+
ValidatorMediaTypeDescriptor Validator = v1.MediaTypeDescriptor
26+
ValidatorMediaTypeManifest Validator = v1.MediaTypeImageManifest
27+
ValidatorMediaTypeManifestList Validator = v1.MediaTypeImageManifestList
28+
ValidatorMediaTypeImageConfig Validator = v1.MediaTypeImageConfig
29+
ValidatorTypeImageLayout Validator = v1.ImageLayoutFile
30+
ValidatorMediaTypeImageLayer unimplemented = v1.MediaTypeImageLayer
3131
)
3232

3333
var (
@@ -37,11 +37,11 @@ var (
3737

3838
// specs maps OCI schema media types to schema files.
3939
specs = map[Validator]string{
40-
MediaTypeDescriptor: "content-descriptor.json",
41-
MediaTypeManifest: "image-manifest-schema.json",
42-
MediaTypeManifestList: "manifest-list-schema.json",
43-
MediaTypeImageConfig: "config-schema.json",
44-
TypeImageLayout: "image-layout-schema.json",
40+
ValidatorMediaTypeDescriptor: "content-descriptor.json",
41+
ValidatorMediaTypeManifest: "image-manifest-schema.json",
42+
ValidatorMediaTypeManifestList: "manifest-list-schema.json",
43+
ValidatorMediaTypeImageConfig: "config-schema.json",
44+
ValidatorTypeImageLayout: "image-layout-schema.json",
4545
}
4646
)
4747

schema/validator.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ type Validator string
3333
type validateDescendantsFunc func(r io.Reader) error
3434

3535
var mapValidateDescendants = map[Validator]validateDescendantsFunc{
36-
MediaTypeManifest: validateManifestDescendants,
36+
ValidatorMediaTypeManifest: validateManifestDescendants,
3737
}
3838

3939
// ValidationError contains all the errors that happened during validation.

0 commit comments

Comments
 (0)