Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Notebook-controller unit-test are failing. #203

Closed
harshad16 opened this issue Oct 17, 2023 · 1 comment · Fixed by #215
Closed

[Bug] Notebook-controller unit-test are failing. #203

harshad16 opened this issue Oct 17, 2023 · 1 comment · Fixed by #215
Assignees
Labels
kind/bug Something isn't working priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)

Comments

@harshad16
Copy link
Member

harshad16 commented Oct 17, 2023

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

While trying to run the notebook-controller unit test from the Makefile.
The go module build phase is failing.

note: module requires Go 1.19
# go.uber.org/multierr
/go/pkg/mod/go.uber.org/[email protected]/error.go:224:13: undefined: atomic.Bool
note: module requires Go 1.19
  * could not run steps: step odh-notebook-controller-unit failed: "odh-notebook-controller-unit" test steps failed: "odh-notebook-controller-unit" pod "odh-notebook-controller-unit-unit" failed: could not watch pod: the pod ci-op-03sfhx4j/odh-notebook-controller-unit-unit failed after 1m49s (failed containers: test): ContainerFailed one or more containers exited

Reference: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/opendatahub-io_kubeflow/201/pull-ci-opendatahub-io-kubeflow-v1.7-branch-odh-notebook-controller-unit/1713548179993006080

@shalberd
Copy link

shalberd commented Oct 19, 2023

yes, I am hitting that error due to go.mod for kubeflow-notebook-controller and odh-notebook-controller unit tests in my PR.

Kubeflow notebook controller depends on components/common as well, and upstream, none of those are greater than go 1.17 in go.mod. It being dependent on go version 19 for the ci prow tests really a good idea in that regard?

#133 (comment)

@harshad16 harshad16 changed the title [Bug] Notebook-controller dockerfiles builts are failing. [Bug] Notebook-controller unit-test are failing. Oct 23, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Oct 24, 2023
@harshad16 harshad16 moved this from 📋 Backlog to ✅Done in ODH IDE Planning Oct 24, 2023
@harshad16 harshad16 self-assigned this Oct 24, 2023
@harshad16 harshad16 added the priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt)
Projects
Status: Done
Status: No status
Archived in project
2 participants