feat: limit data returned when filters are absent

For course- and component-scoped datsets, limit the results of a query
when filter values are absent. This will prevent returning a lot of
data in a way that could be confusing for users.

Author: SoryRawyer

tutoraspects/templates/openedx-assets/assets/charts/Grade_distribution_courses.yaml

@@ -24,7 +24,7 @@ params:
     - null
     - null
   y_axis_format: SMART_NUMBER
-slice_name: Grade distribution - courses
+slice_name: Grade distribution - course
 uuid: f9adbc85-1f50-4c04-ace3-31ba7390de5e
 version: 1.0.0
 viz_type: dist_bar

tutoraspects/templates/openedx-assets/assets/charts/Grade_distribution_problems.yaml

@@ -24,7 +24,7 @@ params:
     - null
     - null
   y_axis_format: SMART_NUMBER
-slice_name: Grade distribution - problems
+slice_name: Grade distribution - problem
 uuid: 4f7e3606-f5de-4643-97c0-bbb6340a3df2
 version: 1.0.0
 viz_type: dist_bar

tutoraspects/templates/openedx-assets/assets/dashboards/Instructor_dashboard.yaml

@@ -25,6 +25,8 @@ metadata:
     - 47
     - 48
     - 52
+    - 865
+    - 879
     controlValues:
       enableEmptyFilter: false
     defaultDataMask:
@@ -186,9 +188,10 @@ metadata:
     - 45
     - 46
     - 47
+    - 865
     controlValues:
-      defaultToFirstItem: true
-      enableEmptyFilter: true
+      defaultToFirstItem: false
+      enableEmptyFilter: false
       inverseSelection: false
       multiSelect: false
       searchAllOptions: false
@@ -200,7 +203,6 @@ metadata:
     filterType: filter_select
     id: NATIVE_FILTER-6xfFY5VGz
     name: Problem name
-    requiredFirst: true
     scope:
       excluded: []
       rootPath:
@@ -216,10 +218,11 @@ metadata:
     - NATIVE_FILTER-Vx7HxG8_7
     - NATIVE_FILTER-XPuiTOej4
     - NATIVE_FILTER-E6-vOpjZv
-    chartsInScope: []
+    chartsInScope:
+    - 52
     controlValues:
-      defaultToFirstItem: true
-      enableEmptyFilter: true
+      defaultToFirstItem: false
+      enableEmptyFilter: false
       inverseSelection: false
       multiSelect: false
       searchAllOptions: false
@@ -231,12 +234,12 @@ metadata:
     filterType: filter_select
     id: NATIVE_FILTER-V77Ybaw2w
     name: Video name
-    requiredFirst: true
     scope:
       excluded: []
       rootPath:
       - TAB-CLiLC4zxo
-    tabsInScope: []
+    tabsInScope:
+    - TAB-CLiLC4zxo
     targets:
     - column:
         name: video_name

tutoraspects/templates/openedx-assets/queries/fact_course_grades.sql

@@ -2,6 +2,13 @@ with grades as (
     select *
     from {{ DBT_PROFILE_TARGET_DATABASE }}.fact_grades
     where grade_type = 'course'
+    {% raw %}
+    {% if filter_values('course_name') != [] %}
+    and entity_name in {{ filter_values('course_name', remove_filter=True) | where_in }}
+    {% else %}
+    and 0=1
+    {% endif %}
+    {% endraw %}
     {% include 'openedx-assets/queries/common_filters.sql' %}
 ),
 most_recent_grades as (
@@ -35,11 +42,3 @@ from
     grades
     join most_recent_grades
         using (org, course_key, entity_id, actor_id, emission_time)
-where
-    {% raw %}
-    {% if filter_values('course_name') != [] %}
-    entity_name in {{ filter_values('course_name', remove_filter=True) | where_in }}
-    {% else %}
-    entity_name in ('')
-    {% endif %}
-    {% endraw %}

tutoraspects/templates/openedx-assets/queries/fact_problem_grades.sql

@@ -1,8 +1,18 @@
 with grades as (
     select *
     from {{ DBT_PROFILE_TARGET_DATABASE }}.fact_grades
-    where grade_type = 'problem'
-    {% include 'openedx-assets/queries/common_filters.sql' %}
+    where
+        grade_type = 'problem'
+
+        {% raw %}
+        {% if filter_values('problem_name') != [] %}
+        and entity_name in {{ filter_values('problem_name', remove_filter=True) | where_in }}
+        {% else %}
+        and 1=0
+        {% endif %}
+        {% endraw %}
+
+        {% include 'openedx-assets/queries/common_filters.sql' %}
 ),
 most_recent_grades as (
     select
@@ -35,11 +45,3 @@ from
     grades
     join most_recent_grades
         using (org, course_key, entity_id, actor_id, emission_time)
-where
-    {% raw %}
-    {% if filter_values('problem_name') != [] %}
-    entity_name in {{ filter_values('problem_name', remove_filter=True) | where_in }}
-    {% else %}
-    entity_name in ('')
-    {% endif %}
-    {% endraw %}

tutoraspects/templates/openedx-assets/queries/fact_problem_responses.sql

@@ -2,7 +2,13 @@ with problem_responses as (
 select *
 from {{ DBT_PROFILE_TARGET_DATABASE }}.fact_problem_responses
 where
-    1=1
+    {% raw %}
+    {% if filter_values('problem_name') != [] %}
+    problem_name in {{ filter_values('problem_name') | where_in }}
+    {% else %}
+    1=0
+    {% endif %}
+    {% endraw %}
     {% include 'openedx-assets/queries/common_filters.sql' %}
 )
 

tutoraspects/templates/openedx-assets/queries/fact_transcript_usage.sql

@@ -2,7 +2,13 @@ with transcripts as (
 select *
 from {{ DBT_PROFILE_TARGET_DATABASE }}.fact_transcript_usage
 where
-    1=1
+    {% raw %}
+    {% if filter_values('video_name') != [] %}
+    video_name in {{ filter_values('video_name', remove_filter=True) | where_in }}
+    {% else %}
+    0=1
+    {% endif %}
+    {% endraw %}
     {% include 'openedx-assets/queries/common_filters.sql' %}
 )
 

tutoraspects/templates/openedx-assets/queries/fact_video_plays.sql

@@ -2,7 +2,13 @@ with plays as (
 select *
 from {{ DBT_PROFILE_TARGET_DATABASE }}.fact_video_plays
 where
-    1=1
+    {% raw %}
+    {% if filter_values('video_name') != [] %}
+    video_name in {{ filter_values('video_name') | where_in }}
+    {% else %}
+    1=0
+    {% endif %}
+    {% endraw %}
     {% include 'openedx-assets/queries/common_filters.sql' %}
 )
 

tutoraspects/templates/openedx-assets/queries/fact_watched_video_segments.sql

@@ -1,34 +1,28 @@
-with starts as (
-    select
-        emission_time,
+with video_events as (
+    emission_time,
         org,
         course_key,
         splitByString('/xblock/', object_id)[-1] as video_id,
         actor_id,
         verb_id,
         video_position
     from {{ ASPECTS_XAPI_DATABASE }}.{{ ASPECTS_VIDEO_PLAYBACK_EVENTS_TABLE }}
-    where
-        verb_id = 'https://w3id.org/xapi/video/verbs/played'
-        {% include 'openedx-assets/queries/common_filters.sql' %}
+    where 1=1
+    {% include 'openedx-assets/queries/common_filters.sql' %}
+), starts as (
+    select *
+    from video_events
+    where verb_id = 'https://w3id.org/xapi/video/verbs/played'
 ), ends as (
-    select
-        emission_time,
-        org,
-        course_key,
-        splitByString('/xblock/', object_id)[-1] as video_id,
-        actor_id,
-        verb_id,
-        video_position
-    from {{ ASPECTS_XAPI_DATABASE }}.{{ ASPECTS_VIDEO_PLAYBACK_EVENTS_TABLE }}
+    select *
+    from video_events
     where
         verb_id in (
             'http://adlnet.gov/expapi/verbs/completed',
             'https://w3id.org/xapi/video/verbs/seeked',
             'https://w3id.org/xapi/video/verbs/paused',
             'http://adlnet.gov/expapi/verbs/terminated'
         )
-        {% include 'openedx-assets/queries/common_filters.sql' %}
 ), segments as(
     select
         starts.org as org,
@@ -76,3 +70,11 @@ select
     started_at,
     arrayJoin(range(start_position, end_position, 5)) as segment_start
 from enriched_segments
+where
+    {% raw %}
+    {% if filter_values('video_name') != [] %}
+    video_name in {{ filter_values('video_name') | where_in }}
+    {% else %}
+    1=0
+    {% endif %}
+    {% endraw %}