Use alternative approach to extract from installer container

Author: stbenjam

03_build_installer.sh

@@ -15,6 +15,7 @@ mkdir -p $OCP_DIR
 if [ -z "$KNI_INSTALL_FROM_GIT" ]; then
   # Extract openshift-install from the release image
   extract_installer "${OPENSHIFT_RELEASE_IMAGE}" $OCP_DIR
+  extract_rhcos_json "${OPENSHIFT_RELEASE_IMAGE}" $OCP_DIR
 else
   # Clone and build the installer from source
   clone_installer

ocp_install_env.sh

@@ -39,6 +39,24 @@ function extract_installer() {
     extract_command openshift-baremetal-install "$1" "$2"
 }
 
+function extract_rhcos_json() {
+    local release_image
+    local outdir
+
+    release_image="$1"
+    outdir="$2"
+    pullsecret_file=$(mktemp "pullsecret--XXXXXXXXXX")
+
+    echo "${PULL_SECRET}" > "${pullsecret_file}"
+
+    baremetal_image=$(oc adm release info --image-for=baremetal-installer --registry-config "$pullsecret_file" "$release_image")
+    baremetal_container=$(podman create "$baremetal_image")
+
+    # This is OK to fail as rhcos.json isn't available in every release,
+    # we'll download it from github if it's not available
+    podman cp "$baremetal_container":/var/cache/rhcos.json "$outdir" || true
+}
+
 function clone_installer() {
   # Clone repo, if not already present
   if [[ ! -d $OPENSHIFT_INSTALL_PATH ]]; then

rhcos.sh

@@ -1,23 +1,15 @@
-# If we're in OpenShift CI, get the sha for our PR. The one openshift-install version
-# reports isn't correct due to how CI rebases the PR before building.
-#
-# FIXME(stbenjam): If a PR branch is not current with master, there is a
-# potential for rhcos.json to be out of date. The potential solutions to
-# this are not ideal, we'll either have to checkout the repo ourselves and
-# check or make a bunch of API calls to see if the PR modified
-# rhcos.json, otherwise just always get master.
-if [[ "$JOB_NAME" =~ "openshift-installer" ]]; then
-  OPENSHIFT_INSTALL_COMMIT=${PULL_PULL_SHA:-$(echo "$JOB_SPEC" | jq -r '.refs.pulls[0].sha')}
+if [[ -f "$OCP_DIR/rhcos.json" ]]; then
+  MACHINE_OS_IMAGE_JSON=$(cat "$OCP_DIR/rhcos.json")
 else
   # Get the git commit that the openshift installer was built from
   OPENSHIFT_INSTALL_COMMIT=$($OPENSHIFT_INSTALLER version | grep commit | cut -d' ' -f4)
-fi
 
-# Get the rhcos.json for that commit
-OPENSHIFT_INSTALLER_MACHINE_OS=${OPENSHIFT_INSTALLER_MACHINE_OS:-https://raw.githubusercontent.com/openshift/installer/$OPENSHIFT_INSTALL_COMMIT/data/data/rhcos.json}
+  # Get the rhcos.json for that commit
+  OPENSHIFT_INSTALLER_MACHINE_OS=${OPENSHIFT_INSTALLER_MACHINE_OS:-https://raw.githubusercontent.com/openshift/installer/$OPENSHIFT_INSTALL_COMMIT/data/data/rhcos.json}
 
-# Get the rhcos.json for that commit, and find the baseURI and openstack image path
-MACHINE_OS_IMAGE_JSON=$(curl "${OPENSHIFT_INSTALLER_MACHINE_OS}")
+  # Get the rhcos.json for that commit, and find the baseURI and openstack image path
+  MACHINE_OS_IMAGE_JSON=$(curl "${OPENSHIFT_INSTALLER_MACHINE_OS}")
+fi
 
 export MACHINE_OS_INSTALLER_IMAGE_URL=$(echo "${MACHINE_OS_IMAGE_JSON}" | jq -r '.baseURI + .images.openstack.path')
 export MACHINE_OS_INSTALLER_IMAGE_SHA256=$(echo "${MACHINE_OS_IMAGE_JSON}" | jq -r '.images.openstack.sha256')