Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending /etc/hosts is triggering master reboot cycles #63

Closed
wking opened this issue Dec 8, 2018 · 7 comments
Closed

Appending /etc/hosts is triggering master reboot cycles #63

wking opened this issue Dec 8, 2018 · 7 comments

Comments

@wking
Copy link
Member

wking commented Dec 8, 2018

Since #56, this operator has been adding content to /etc/hosts. But that file is managed by the machine-config daemon, and when the MCD detects the altered content, it reboots the node. The node comes back up, and tries to restore the expected pods, and presumably the whole cycle repeats again. This makes it harder for external clients to connect to the Kubernetes and OpenShift API servers (openshift/origin#21612), and that shows up in failed aws-e2e CI runs as random, unrelated flakes. I'm not sure what the /etc/hosts additions are for, but can you find another approach that accomplishes the same goal? Or find some way to ask the MCD to append your content, instead of reaching around the MCD and touching the file directly?

CC @abhinavdahiya, @ironcladlou, @pravisankar

@wking
Copy link
Member Author

wking commented Dec 8, 2018

Possible resolution is for the MCD to stop caring about /etc/hosts: openshift/machine-config-operator#225.

@Miciah
Copy link
Contributor

Miciah commented Dec 10, 2018

I'm not sure what the /etc/hosts additions are for, but can you find another approach that accomplishes the same goal? Or find some way to ask the MCD to append your content, instead of reaching around the MCD and touching the file directly?

We update /etc/hosts to add the registry's name and address so that the container runtime can resolve it. We considered using MCD, but we did not know a way to use it to update the file without triggering a reboot. We did not realize that MCD would trigger a reboot anyway if we modified /etc/hosts ourselves.

@wking
Copy link
Member Author

wking commented Dec 10, 2018

We update /etc/hosts to add the registry's name and address so that the container runtime can resolve it.

Well, with openshift/machine-config-operator#225 landed, the MCD is out of the business of touching /etc/hosts (it had been injecting this). Can you take over exclusive /etc/hosts management in this operator? It seems like a reasonable fit for the DNS operator, but I'm not familiar enough to know.

@ironcladlou
Copy link
Contributor

@knobunc @smarterclayton any concerns with cluster-dns-operator assuming management responsibilities for /etc/hosts for now? I don't know of any other components who need an interface.

@ironcladlou
Copy link
Contributor

@wking want to close this one out as resolved by
openshift/machine-config-operator#225?

@wking
Copy link
Member Author

wking commented Dec 10, 2018

Works for me, just so y'all know you're officially in charge of the file now ;).

@wking wking closed this as completed Dec 10, 2018
@knobunc
Copy link

knobunc commented Dec 10, 2018

@wking cool. Thanks... we just have a different hack to manage the same thing... but a little more dynamically :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants