Skip to content

Commit fe5214e

Browse files
Merge pull request #5882 from rhrazdil/disable-gecko-when-chrome-version
Don't download geckodriver when CHROME_VERSION is defined
2 parents de305a2 + affeaa7 commit fe5214e

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

test-gui.sh

+6-2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,14 @@ set -exuo pipefail
55
cd frontend
66

77
yarn install
8-
if [ -z "${CHROME_VERSION-}" ]; then
8+
if [ "${BRIDGE_E2E_BROWSER_NAME-}" == 'firefox' ]; then
99
yarn run webdriver-update
1010
else
11-
yarn run webdriver-update --versions.chrome="$CHROME_VERSION"
11+
if [ -n "${CHROME_VERSION-}" ]; then
12+
yarn run webdriver-update --versions.chrome="$CHROME_VERSION" --gecko=false
13+
else
14+
yarn run webdriver-update --gecko=false
15+
fi
1216
fi
1317

1418
if [ $# -gt 0 ] && [ -n "$1" ]; then

0 commit comments

Comments
 (0)