Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BESTIARY and BOSSTIARY no longer track #1798

Closed
2 of 5 tasks
Leshyah opened this issue Nov 10, 2023 · 5 comments · Fixed by #1792
Closed
2 of 5 tasks

BESTIARY and BOSSTIARY no longer track #1798

Leshyah opened this issue Nov 10, 2023 · 5 comments · Fixed by #1792
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Leshyah
Copy link
Contributor

Leshyah commented Nov 10, 2023

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

After commit #1757, bestiary and bosstiary no longer track. Technically I can not confirm this commit broke it, but it's the only recent update that has restructured bestiary and bosstiary moving these functions from lua to src. I noticed this issue during the testing of commit #1791.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Leshyah Leshyah added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 10, 2023
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Nov 10, 2023
@luancolombo
Copy link
Contributor

Fiz testes no repo limpo atual, realmente nao esta contando bestiary nem bosstiary

@Schiffers
Copy link
Contributor

Fiz testes no repo limpo atual, realmente nao esta contando bestiary nem bosstiary ²

@Leshyah
Copy link
Contributor Author

Leshyah commented Nov 11, 2023

This issue is now fixed with commit #1792

@Leshyah Leshyah closed this as completed Nov 11, 2023
@Schiffers
Copy link
Contributor

this should be opened again ...
now the counter wiil increase only if you are the mostDamageKiller instead of give a killCounter to everyone who participed in the battle

@dudantas
Copy link
Member

this should be opened again ...
now the counter wiil increase only if you are the mostDamageKiller instead of give a killCounter to everyone who participed in the battle

It's another problem, a new issue must be opened.

@dudantas dudantas mentioned this issue Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always run onKilledCreature for most damage when target is monster opentibiabr/canary
4 participants
@dudantas @Schiffers @luancolombo @Leshyah