Rename alwaysEmitSpans to alwaysReportSpans

Author: drolando

src/Zipkin/DefaultTracing.php

@@ -43,7 +43,7 @@ public function __construct(
         bool $isNoop,
         Propagation $propagation,
         bool $supportsJoin,
-        bool $alwaysEmitSpans = false
+        bool $alwaysReportSpans = false
     ) {
         $this->tracer = new Tracer(
             $localEndpoint,
@@ -53,7 +53,7 @@ public function __construct(
             $currentTraceContext,
             $isNoop,
             $supportsJoin,
-            $alwaysEmitSpans
+            $alwaysReportSpans
         );
 
         $this->propagation = $propagation;

src/Zipkin/Tracer.php

@@ -51,7 +51,7 @@ final class Tracer
     /**
      * @var bool
      */
-    private $alwaysEmitSpans;
+    private $alwaysReportSpans;
 
     /**
      * @param Endpoint $localEndpoint
@@ -60,7 +60,7 @@ final class Tracer
      * @param bool $usesTraceId128bits
      * @param CurrentTraceContext $currentTraceContext
      * @param bool $isNoop
-     * @param bool $alwaysEmitSpans
+     * @param bool $alwaysReportSpans
      */
     public function __construct(
         Endpoint $localEndpoint,
@@ -70,15 +70,15 @@ public function __construct(
         CurrentTraceContext $currentTraceContext,
         bool $isNoop,
         bool $supportsJoin = true,
-        bool $alwaysEmitSpans = false
+        bool $alwaysReportSpans = false
     ) {
         $this->recorder = new Recorder($localEndpoint, $reporter, $isNoop);
         $this->sampler = $sampler;
         $this->usesTraceId128bits = $usesTraceId128bits;
         $this->currentTraceContext = $currentTraceContext;
         $this->isNoop = $isNoop;
         $this->supportsJoin = $supportsJoin;
-        $this->alwaysEmitSpans = $alwaysEmitSpans;
+        $this->alwaysReportSpans = $alwaysReportSpans;
     }
 
     /**
@@ -364,7 +364,7 @@ private function ensureSampled(TraceContext $context): Span
      */
     private function toSpan(TraceContext $context): Span
     {
-        if (!$this->isNoop && ($context->isSampled() || $this->alwaysEmitSpans)) {
+        if (!$this->isNoop && ($context->isSampled() || $this->alwaysReportSpans)) {
             return new RealSpan($context, $this->recorder);
         }
 

src/Zipkin/TracingBuilder.php

@@ -61,7 +61,7 @@ class TracingBuilder
     /**
      * @var bool
      */
-    private $alwaysEmitSpans = false;
+    private $alwaysReportSpans = false;
 
     public static function create(): self
     {
@@ -189,12 +189,12 @@ public function supportingJoin(bool $supportsJoin): self
     }
 
     /**
-     * @param bool $alwaysEmitSpans
+     * @param bool $alwaysReportSpans
      * @return $this
      */
-    public function alwaysEmittingSpans(bool $alwaysEmitSpans): self
+    public function alwaysReportingSpans(bool $alwaysReportSpans): self
     {
-        $this->alwaysEmitSpans = $alwaysEmitSpans;
+        $this->alwaysReportSpans = $alwaysReportSpans;
         return $this;
     }
 
@@ -225,7 +225,7 @@ public function build(): Tracing
             $this->isNoop,
             $propagation,
             $this->supportsJoin && $propagation->supportsJoin(),
-            $this->alwaysEmitSpans
+            $this->alwaysReportSpans
         );
     }
 }

tests/Unit/TracingBuilderTest.php

@@ -89,7 +89,7 @@ private function randomBool()
 
     public function testAlwaysEmitSpans()
     {
-        // If `alwaysEmittingSpans(true)` is called, we should be emitting the
+        // If `alwaysReportingSpans(true)` is called, we should be emitting the
         // spans even if the trace isn't sampled
         $endpoint = Endpoint::createAsEmpty();
         $reporter = new InMemory();
@@ -100,7 +100,7 @@ public function testAlwaysEmitSpans()
             ->havingLocalEndpoint($endpoint)
             ->havingReporter($reporter)
             ->havingSampler($sampler)
-            ->alwaysEmittingSpans(true)
+            ->alwaysReportingSpans(true)
             ->build();
         $tracer = $tracing->getTracer();