Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A large number of edits create an empty changeset #380

Open
deevroman opened this issue Jul 8, 2022 · 12 comments
Open

A large number of edits create an empty changeset #380

deevroman opened this issue Jul 8, 2022 · 12 comments

Comments

@deevroman
Copy link

deevroman commented Jul 8, 2022

If you create an edit package with 100-200 edits, only an empty edit package is created. No error messages appear.

Example changesets:
https://osmcha.org/changesets/123314632
https://osmcha.org/changesets/123337130

@frodrigo
Copy link
Member

The edge case of conflict is not supported. Do you think it is your case ?

@deevroman
Copy link
Author

deevroman commented Jul 10, 2022

I have an idea how to repeat the bug, but without logs it's pretty useless:(

The assumption is the following:
I fixed in both cases only redirects thrust wikidata in http://osmose.openstreetmap.fr/en/map/#item=3031&class=1%2C2%2C3%2C4%2C5%2C6%2C7%2C8%2C9&zoom=7&lat=53.212&lon=38.529&level=1%2C2%2C3&issue_uuid=7f5fbb48-f33a-58c7-90bf-7d676d3ee09a
(That is, these edits only affected the wikidata tag)

The following bug sometimes appears on the site: if you solve problems on one zoom, then change the zoom, then some of the problems may reappear. Maybe I solved these problems again and when sending it caused a conflict.

@frodrigo
Copy link
Member

The following bug sometimes appears on the site: if you solve problems on one zoom, then change the zoom, then some of the problems may reappear. Maybe I solved these problems again and when sending it caused a conflict.

It is a cache issue, to improve server size perf. It is expected. The cache is about 5s.

I don't get any error messages

It is a know issue of no dealing with conflicts.

A solution, if it is this problem. Is to save often. It stay anyway in the same changeset.

@deevroman
Copy link
Author

deevroman commented Jul 11, 2022

The cache is about 5s.

Markers continue to appear on other zooms for much longer than 5 seconds (over a minute)

It is a know issue of no dealing with conflicts.

The problem of conflicts and the lack of error messages are different problems (if I am translating your messages correctly. Is there an issue on this?)

Is to save often.

Maybe inform the user about it? For example, highlight the save button.

@fgouget
Copy link

fgouget commented Jul 23, 2022

A solution, if it is this problem. Is to save often. It stay anyway in the same changeset.

That does not work. I lost changesets with less than 20 modifications which is really not much when fixing addr:street fields. Given its current state Osmose should display a warning telling people not to make changes as there is, in my experience, a > 30% probability their work will be lost.

@GreenAloe
Copy link

GreenAloe commented Sep 18, 2022

I was fixing tags a few hours, saved changes from time to time but did not checked if it was saved. But now I see that only a few changesets were saved. Almost all changes were lost :(

@frodrigo
Copy link
Member

I was fixing tags a few hours, saved changes from time to time but did not checked if it was saved. But now I see that only a few changesets were saved. Almost all changes were lost :(

Sorry to hear that. The upload to osm.org must be reworked. Prior works are already in progress (by slowly).

@fgouget
Copy link

fgouget commented Sep 21, 2022

I also lost about 60 changes last week. Osmose has silently been unusable for a couple of months now :-(

@frodrigo
Copy link
Member

Now Osmose report an error. But the error message does not yet contain if it is about conflict or not.

@HubMiner
Copy link

Thinking how to avoid big changes... Would it be easier to dump conflict details into browser console add maybe a GUI message to check console?

@frodrigo
Copy link
Member

Thinking how to avoid big changes... Would it be easier to dump conflict details into browser console add maybe a GUI message to check console?

The UI already display the message send by the API. But the API only send a generic message.

@Marc-marc-marc
Copy link

It is a know issue of no dealing with conflicts.

if error, send the objects one by one or divide the group by 2 for each error if you want to optimise uploading (if a group of 64 objects causes an error, try with the first 32, if that fails try with the first 16)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants