Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story][CL]: Simulator testing for concentrated liquidity #4027

Closed
4 of 6 tasks
Tracked by #3014
p0mvn opened this issue Jan 16, 2023 · 4 comments
Closed
4 of 6 tasks
Tracked by #3014

[Story][CL]: Simulator testing for concentrated liquidity #4027

p0mvn opened this issue Jan 16, 2023 · 4 comments
Assignees
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic

Comments

@p0mvn
Copy link
Member

p0mvn commented Jan 16, 2023

Background

As an engineer, I would like to have randomized testing for concentrated liquidity, so that I can be more confident that the core logic works as expected under various situations

Suggested Design

Implement a simulator for all concentrated liquidity messages, that would be similar with the gamm simulator( cref: https://github.com/osmosis-labs/osmosis/tree/main/x/gamm/simulation)

Tasks

We want to have the following components tested via simulator

We also want to add simulator testings for the pool manager module if possible

Acceptance Criteria

  • simulator is implemented for concentrated liquidity
  • all messages are tested
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 16, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 16, 2023
@mattverse mattverse assigned mattverse and unassigned mattverse Jan 19, 2023
@p0mvn p0mvn added the T:story A story belongs to an epic label Jan 24, 2023
@stackman27 stackman27 self-assigned this Jan 24, 2023
@mattverse mattverse removed their assignment Jan 25, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Jan 26, 2023

Hi @stackman27. Could you please break this down into tasks?

@stackman27
Copy link
Contributor

yup will do apologies for the delay

@stackman27
Copy link
Contributor

#4241 blocked by #4366

@stackman27 stackman27 moved this from Needs Triage 🔍 to In Progress🏃 in Osmosis Chain Development Feb 27, 2023
@p0mvn p0mvn moved this from In Progress🏃 to Todo 🕒 in Osmosis Chain Development Mar 26, 2023
@p0mvn p0mvn moved this from Todo 🕒 to Needs PR Review in Osmosis Chain Development Apr 17, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Apr 25, 2023

Addressed now

@p0mvn p0mvn closed this as completed Apr 25, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic
Projects
Archived in project
Development

No branches or pull requests

3 participants