Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pacts to be published to a broker with a custom certificate #11

Closed
bethesque opened this issue Feb 8, 2018 · 6 comments
Closed

Comments

@bethesque
Copy link
Member

SSL_CERT_FILE and SSL_CERT_DIR are cleared by Travelling Ruby. Find out why this is done, and if it can be skipped.

@winfieldaj
Copy link

@bethesque I am not sure if there is a difference in "pact-standalone" and "pact-ruby-standalone" but I found this issue in pact-standalone.

The issue is in the @pact-foundation\pact-standalone\platforms\win32\lib\ruby\bin\ruby.bat. As well as in the respective files for the other OSs.

In my testing, if I have preset the "SSL_CERT_FILE" to a private cert file it is over written by line 22.

Possible fix would be to not set this if it already contains a value.

@bethesque
Copy link
Member Author

It should be fixed now. Have a look at the referenced commit.

@bethesque
Copy link
Member Author

bethesque commented Feb 8, 2018

Which wrapper language are you using?

@bethesque
Copy link
Member Author

bethesque commented Feb 9, 2018

If you're after pact-js, a new version has now been released. Let me know how it goes.

@winfieldaj
Copy link

@bethesque Sorry for the delay. I am currently waiting on my build team to white list this version and put it in our nexus repository so I can test on our linux build platform. It is looking like that is not going to happen until sometime next week so I will test then and report back.

I am using pact-js

@adambeben
Copy link

I can confirm this is still relevant. SSL_CERT_FILE is overwritten to ...\pact\lib\ruby\bin\..\lib\ca-bundle.crt when running pact-provider-verifier.bat.
Running pact-1.64.1-win32 on Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants