Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run test suite against both React 15 & 16 #1659

Closed
giladgray opened this issue Oct 4, 2017 · 1 comment
Closed

run test suite against both React 15 & 16 #1659

giladgray opened this issue Oct 4, 2017 · 1 comment
Assignees
@adidahiya
Labels
Domain: testing Resolution: won't fix Type: breaking change
Milestone
2.0.0

Comments

@giladgray
Copy link
Contributor

Enzyme 2.x does not support React 16 and migrating to Enzyme 3.x is not trivial. Fortunately, Enzyme 3 makes testing against multiple versions of React quite possible!

For 2.0, we should run the test suite against both React 15 and 16, in parallel CircleCI containers.

This issue is casually blocked on the non-existence of @types/enzyme for 3.x.

Related: #866 (comment)
@giladgray giladgray added this to the 2.0.0 milestone Oct 4, 2017
@giladgray giladgray mentioned this issue Oct 4, 2017
Merged
@adidahiya
Copy link
Contributor

we decided not to do this since we're enforcing a minimum dep on React 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
Domain: testing Resolution: won't fix Type: breaking change
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@giladgray @adidahiya