Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dist/ submodule paths #1929

Closed
adidahiya opened this issue Dec 15, 2017 · 0 comments
Closed

Refactor dist/ submodule paths #1929

adidahiya opened this issue Dec 15, 2017 · 0 comments
Assignees
@adidahiya
Labels
Type: breaking change Type: refactor
Milestone
2.0.0

Comments

@adidahiya
Copy link
Contributor

adidahiya commented Dec 15, 2017 •
edited
Loading

Right now we have

  • dist/ for CJS modules, CSS, variables.scss, variables.less
  • dist/esm/ for ES modules
  • src/ for Sass & TS sources

I propose:

  • lib/css/ for styles
  • lib/scss/ for variables.scss
  • lib/less/ for variables.less
  • lib/cjs/ for CJS modules
  • lib/esm/ for ES modules
  • dist/ for UMD bundles (core.bundle.js)
  • src/ for Sass & TS sources (sourcemaps work best this way)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adidahiya adidahiya

Labels
Type: breaking change Type: refactor
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@adidahiya