Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Menu tests skip'd in the Popover => Popover2 transition #2008

Closed
cmslewis opened this issue Jan 16, 2018 · 0 comments
Closed

Fix Menu tests skip'd in the Popover => Popover2 transition #2008

cmslewis opened this issue Jan 16, 2018 · 0 comments

Comments

@cmslewis
Copy link
Contributor

cmslewis commented Jan 16, 2018

I it.skip'd the following tests during the 2.0 transition promoting Popover2 to the core popover component. Need to get them working again and re-enable them:

// menuTests.tsx
- "children will continue displaying in the same direction if possible"
- "children will flip direction after no more room in the existing direction"

Note: anecdotally, the functionality above does still work in practice; it's just the tests that are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants