Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy Tooltip #2220

Closed
tgreen7 opened this issue Mar 12, 2018 · 7 comments
Closed

Buggy Tooltip #2220

tgreen7 opened this issue Mar 12, 2018 · 7 comments

Comments

@tgreen7
Copy link
Contributor

tgreen7 commented Mar 12, 2018

Bug report

  • Package version(s): 2.0.0-rc.2
  • Browser and OS versions: Chrome 64.0.3282.186, MacOS 10.13.3

buggy-popover

here is a site with a demo of the problem:
https://tgreen7.github.io/blueprint-test/

here is the code:
https://github.com/tgreen7/blueprint-test

@tnrich
Copy link
Contributor

tnrich commented Mar 12, 2018

I'm seeing an even weirder bug.. Too strange to really believe. In my code if I change the tooltip text from "Hide cut sites" to "Hide features" an infinite loop is hit and my app crashes.

I'll try to reproduce this in a minimal example, but this has to be one of the strangest bugs I have ever seen..

@tnrich
Copy link
Contributor

tnrich commented Mar 12, 2018

I think mine might be related to #2030

Has a fix been released for that yet?

@adidahiya
Copy link
Contributor

@tnrich yeah, you can trace the tags which include the commit which fixed #2030: ff76c4a

@giladgray
Copy link
Contributor

@tgreen7 try disabling the preventOverflow modifier from popper:
<Popover modifiers={{ preventOverflow: { enabled: false } }} ... />

@tgreen7
Copy link
Contributor Author

tgreen7 commented Mar 20, 2018

@giladgray Thanks so much! That did it.

@tgreen7 tgreen7 closed this as completed Mar 20, 2018
@tgreen7
Copy link
Contributor Author

tgreen7 commented Mar 28, 2018

for future use popover throws a bunch of warnings if you add the above code. You must disable hide.
<Popover modifiers={{ preventOverflow: { enabled: false }, hide: { enabled: false } }} ... />

@tgreen7
Copy link
Contributor Author

tgreen7 commented Jan 17, 2019

This seems like it was changed again in version 3.9.0 as can be seen here https://github.com/palantir/blueprint/compare/@blueprintjs/[email protected]...@blueprintjs/[email protected]

To override this change and get a tooltip working outside of its boundaries you need to add these modifiers:

{
  preventOverflow: { enabled: false, },
  hide: {
    enabled: false
  },
  flip: {
    boundariesElement: 'viewport'
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants