From 701f55e12a81df6ccca008e4b9fe32af8dc60b6e Mon Sep 17 00:00:00 2001 From: Adi Dahiya Date: Mon, 15 Jan 2018 14:28:06 -0500 Subject: [PATCH 1/7] Output library assets in /lib/ paths --- .gitignore | 1 + packages/core/package.json | 10 +++++----- packages/core/src/docs/variables.md | 8 +++++++- packages/core/src/tsconfig.cjs.json | 2 +- packages/core/src/tsconfig.json | 2 +- packages/core/test/isotest.js | 2 +- packages/datetime/karma.conf.js | 4 ++-- packages/datetime/package.json | 10 +++++----- packages/datetime/src/tsconfig.cjs.json | 2 +- packages/datetime/src/tsconfig.json | 2 +- packages/docs-app/src/blueprint.md | 19 +++++++++++-------- .../datetime-examples/timePickerExample.tsx | 2 +- packages/docs-app/src/index.scss | 16 ++++++++-------- packages/docs-theme/package.json | 10 +++++----- packages/docs-theme/src/tsconfig.cjs.json | 2 +- packages/docs-theme/src/tsconfig.json | 2 +- packages/icons/package.json | 10 +++++----- packages/icons/src/_font-imports.scss | 2 +- packages/icons/src/tsconfig.cjs.json | 2 +- packages/icons/src/tsconfig.json | 2 +- packages/labs/karma.conf.js | 4 ++-- packages/labs/package.json | 10 +++++----- packages/labs/src/tsconfig.cjs.json | 2 +- packages/labs/src/tsconfig.json | 2 +- packages/landing-app/src/_overrides.scss | 2 +- packages/landing-app/src/index.scss | 2 +- .../node-build-scripts/generate-css-variables | 6 +++--- packages/node-build-scripts/sass-compile | 2 +- packages/select/karma.conf.js | 4 ++-- packages/select/package.json | 10 +++++----- packages/select/src/tsconfig.cjs.json | 2 +- packages/select/src/tsconfig.json | 2 +- packages/table-dev-app/src/index.scss | 4 ++-- packages/table/karma.conf.js | 4 ++-- packages/table/package.json | 10 +++++----- packages/table/src/tsconfig.cjs.json | 2 +- packages/table/src/tsconfig.json | 2 +- packages/table/test/harness.ts | 2 +- packages/timezone/karma.conf.js | 4 ++-- packages/timezone/package.json | 10 +++++----- packages/timezone/src/tsconfig.cjs.json | 2 +- packages/timezone/src/tsconfig.json | 2 +- 42 files changed, 105 insertions(+), 95 deletions(-) diff --git a/.gitignore b/.gitignore index 5e6513daa3f..eb4ce4de76d 100644 --- a/.gitignore +++ b/.gitignore @@ -20,6 +20,7 @@ yarn-error.log # Blueprint build dist +lib generated coverage /docs diff --git a/packages/core/package.json b/packages/core/package.json index a6526df7705..cbb81161144 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -2,17 +2,17 @@ "name": "@blueprintjs/core", "version": "1.35.0", "description": "Core styles & components", - "main": "dist/index.js", - "module": "dist/esm/index.js", - "typings": "dist/esm/index.d.ts", - "style": "dist/blueprint.css", + "main": "lib/cjs/index.js", + "module": "lib/esm/index.js", + "typings": "lib/esm/index.d.ts", + "style": "lib/css/blueprint.css", "unpkg": "dist/core.bundle.js", "scripts": { "compile": "npm-run-all -p 'compile:*'", "compile:esm": "tsc -p ./src", "compile:cjs": "tsc -p ./src/tsconfig.cjs.json", "compile:css": "sass-compile ./src", - "clean": "rm -rf dist/*", + "clean": "rm -rf dist/* && rm -rf lib/*", "dev": "npm-run-all -p 'compile:esm -- --watch' 'compile:css -- --watch'", "dist": "npm-run-all -s 'dist:*'", "dist:bundle": "NODE_ENV=production webpack", diff --git a/packages/core/src/docs/variables.md b/packages/core/src/docs/variables.md index 23058351abe..347db617c31 100644 --- a/packages/core/src/docs/variables.md +++ b/packages/core/src/docs/variables.md @@ -3,7 +3,13 @@ Available for use with Sass and Less. ```css.scss -@import "path/to/@blueprintjs/core/dist/variables"; +// Sass +@import "path/to/@blueprintjs/core/lib/scss/variables"; +``` + +```css.less +// Less +@import "path/to/@blueprintjs/core/lib/less/variables"; ``` The Sass `$` convention is used in this documentation for consistency with the original source code. diff --git a/packages/core/src/tsconfig.cjs.json b/packages/core/src/tsconfig.cjs.json index 89e06b4b44e..54b20e53e7b 100644 --- a/packages/core/src/tsconfig.cjs.json +++ b/packages/core/src/tsconfig.cjs.json @@ -2,6 +2,6 @@ "extends": "./tsconfig", "compilerOptions": { "module": "commonjs", - "outDir": "../dist" + "outDir": "../lib/cjs" } } diff --git a/packages/core/src/tsconfig.json b/packages/core/src/tsconfig.json index 1fa5548ec3d..b4fa3674bf5 100644 --- a/packages/core/src/tsconfig.json +++ b/packages/core/src/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../../config/tsconfig.base", "compilerOptions": { - "outDir": "../dist/esm" + "outDir": "../lib/esm" } } diff --git a/packages/core/test/isotest.js b/packages/core/test/isotest.js index 2356ecc7021..23be3ecda3e 100644 --- a/packages/core/test/isotest.js +++ b/packages/core/test/isotest.js @@ -5,7 +5,7 @@ const { generateIsomorphicTests } = require("@blueprintjs/test-commons"); const React = require("react"); -// TODO: get this to work with require("@std/esm")(module)("../dist/esm") +// TODO: get this to work with require("@std/esm")(module)("../lib/esm") const Core = require("../dist"); const tooltipContent = { content: React.createElement("h1", {}, "content") }; diff --git a/packages/datetime/karma.conf.js b/packages/datetime/karma.conf.js index e7a4587464d..0e3a8a9c038 100644 --- a/packages/datetime/karma.conf.js +++ b/packages/datetime/karma.conf.js @@ -15,8 +15,8 @@ module.exports = function (config) { entry: { datetime: [ path.resolve(__dirname, "test/index.ts"), - path.resolve(__dirname, "../core/dist/blueprint.css"), - path.resolve(__dirname, "dist/blueprint-datetime.css"), + path.resolve(__dirname, "../core/lib/css/blueprint.css"), + path.resolve(__dirname, "lib/css/blueprint-datetime.css"), ], }, }), diff --git a/packages/datetime/package.json b/packages/datetime/package.json index 9274bc7ff10..ede7fb39d11 100644 --- a/packages/datetime/package.json +++ b/packages/datetime/package.json @@ -2,17 +2,17 @@ "name": "@blueprintjs/datetime", "version": "1.25.1", "description": "Components for interacting with dates and times", - "main": "dist/index.js", - "module": "dist/esm/index.js", - "typings": "dist/esm/index.d.ts", - "style": "dist/blueprint-datetime.css", + "main": "lib/cjs/index.js", + "module": "lib/esm/index.js", + "typings": "lib/esm/index.d.ts", + "style": "lib/css/blueprint-datetime.css", "unpkg": "dist/datetime.bundle.js", "scripts": { "compile": "npm-run-all -p 'compile:*'", "compile:esm": "tsc -p ./src", "compile:cjs": "tsc -p ./src/tsconfig.cjs.json", "compile:css": "sass-compile ./src", - "clean": "rm -rf dist/*", + "clean": "rm -rf dist/* && rm -rf lib/*", "dev": "npm-run-all -p 'compile:esm -- --watch' 'compile:css -- --watch'", "dist": "npm-run-all -s 'dist:*'", "dist:bundle": "NODE_ENV=production webpack", diff --git a/packages/datetime/src/tsconfig.cjs.json b/packages/datetime/src/tsconfig.cjs.json index 89e06b4b44e..54b20e53e7b 100644 --- a/packages/datetime/src/tsconfig.cjs.json +++ b/packages/datetime/src/tsconfig.cjs.json @@ -2,6 +2,6 @@ "extends": "./tsconfig", "compilerOptions": { "module": "commonjs", - "outDir": "../dist" + "outDir": "../lib/cjs" } } diff --git a/packages/datetime/src/tsconfig.json b/packages/datetime/src/tsconfig.json index 1fa5548ec3d..b4fa3674bf5 100644 --- a/packages/datetime/src/tsconfig.json +++ b/packages/datetime/src/tsconfig.json @@ -1,6 +1,6 @@ { "extends": "../../../config/tsconfig.base", "compilerOptions": { - "outDir": "../dist/esm" + "outDir": "../lib/esm" } } diff --git a/packages/docs-app/src/blueprint.md b/packages/docs-app/src/blueprint.md index 160cf9437ab..bbc7da9bed8 100644 --- a/packages/docs-app/src/blueprint.md +++ b/packages/docs-app/src/blueprint.md @@ -81,7 +81,7 @@ Blueprint as well. Some Blueprint components use the following ES2015 features: ... - + ... ... @@ -101,7 +101,8 @@ Blueprint supports the venerable [unpkg CDN](https://unpkg.com). Each package pr library on the `Blueprint` global variable: `Blueprint.Core`, `Blueprint.Datetime`, etc. These bundles _do not include_ external dependencies; your application will need to ensure that -`normalize.css`, `React`, `classnames`, and `Tether` are available at runtime. +`normalize.css`, `react`, `react-dom`, `react-transition-group`, `classnames`, `popper.js`, and +`react-popper`are available at runtime. ```html @@ -110,16 +111,18 @@ These bundles _do not include_ external dependencies; your application will need Blueprint Starter Kit - - + + - - - - + + + + + +