Incorrect balance and refundAddress for contract suicide

[iulian-taraboanta]

Describe the bug

In Block: 19922930, Transaction hash: 0x70395fe67f2fdfa947fc6a15e2819a3b882e8b25760b1160b8bad7b19d1cb1a3

https://etherscan.io/tx/0x70395fe67f2fdfa947fc6a15e2819a3b882e8b25760b1160b8bad7b19d1cb1a3

The result of trace_replayBlockTransactions:

"type": "suicide", "action": { "address": "0xd8d93bf08a5634eac548e17b1741f4f23995cf4a", "balance": "0x0", "refundAddress": "0x0000000000000000000000000000000000000000" }, "result": null, "subtraces": 0, "traceAddress": [ 0 ]

balance and refundAddress are both 0x0

Erigon reply for same transaction:

"action": { "address": "0xd8d93bf08a5634eac548e17b1741f4f23995cf4a", "refundAddress": "0x3b2b1f5fb4a8a4ad3c511970456877a52bb0f383", "balance": "0x6f05b59d3b20000" }, "result": null, "subtraces": 0, "traceAddress": [ 0 ], "type": "suicide" } ],

Another example:
https://etherscan.io/tx/0xd927843e30c6b2bf43103d83bca6abead648eac3cad0d05b1b0eb84cd87de9b6

{ "type": "suicide", "action": { "address": "0xfaddf57d079b01e53d1fe3476cc83e9bcc705854", "balance": "0x0", "refundAddress": "0x0000000000000000000000000000000000000000" }, "result": null, "subtraces": 0, "traceAddress": [ 0, 3, 33 ] },

Steps to reproduce

curl -X POST IP:PORT -H "content-type: application/json" --data '{"id":0,"params":["0x12FFFF2",["trace"]],"method":"trace_replayBlockTransactions","jsonrpc":"2.0"}' | jq

Node logs

No response

Platform(s)

Linux (x86)

What version/commit are you on?

reth Version: 1.0.6

What database version are you on?

Current database version: 2
Local database version: 2

Which chain / network are you on?

mainnet

What type of node are you running?

Archive (default)

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

• I agree to follow the Code of Conduct

[emhane]

should alloy_rpc_types_trace::Action mirror alloy_primitives::TxKind?
https://github.com/alloy-rs/alloy/blob/4492c25f1a666881d18367dc47d0040fc05b17ae/crates/rpc-types-trace/src/parity.rs#L162-L177
https://github.com/alloy-rs/core/blob/00076ee9078fc02bd78660a83d9b2ce2209d2be6/crates/primitives/src/common.rs#L6-L17

@onbjerg @DaniPopes @rakita

[DaniPopes]

not sure what you mean by mirroring here

cc @jsvisa

[jsvisa]

I think this issue had been fixed by bluealloy/revm#1746

[emhane]

blocked by next revm release

[emhane]

@iulian-taraboanta do you have capacity to verify if #11063 fixes this?

[mattsse]

optimistically marking this as fixed

[iulian-taraboanta]

@iulian-taraboanta do you have capacity to verify if #11063 fixes this?

@emhane I verified it, issue is fixed. Thank you!