Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validate_requests fn into validate version specific fields for ethereum engine validator #14933

Open
mattsse opened this issue Mar 10, 2025 · 0 comments
Open

Move validate_requests fn into validate version specific fields for ethereum engine validator #14933

mattsse opened this issue Mar 10, 2025 · 0 comments
Assignees
@fgimenez
Labels
A-engine Related to the engine implementation C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 10, 2025

Describe the feature

ref #14932

after we transitioned the engine api to operate on the entire executiondata we stopped calling
https://github.com/paradigmxyz/reth/blob/main/crates/engine/primitives/src/lib.rs#L140-L140

so we can remove this function and move this to the ethereum specific impl instead

https://github.com/paradigmxyz/reth/blob/main/crates/ethereum/node/src/engine.rs#L54-L54

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 10, 2025
@mattsse mattsse added A-engine Related to the engine implementation and removed S-needs-triage This issue needs to be labelled labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgimenez fgimenez

Labels
A-engine Related to the engine implementation C-enhancement New feature or request
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fgimenez @mattsse